You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/05/25 17:10:07 UTC

[GitHub] [sling-org-apache-sling-starter] bdelacretaz commented on a change in pull request #24: SLING-10402 - run SmokeIT on both tar and mongo features

bdelacretaz commented on a change in pull request #24:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/24#discussion_r638998848



##########
File path: src/main/features/oak/persistence/oak_persistence_mongods.json
##########
@@ -13,7 +16,7 @@
     "configurations":{
         "org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService":{
             "db":"sling",
-            "mongouri":"mongodb://localhost:27017"
+            "mongouri":"mongodb://localhost:${mongo.port}"

Review comment:
       This would have meant adding a dependency to that plugin for Sling starter users, right? If the syntax is used in a feature model file that we distribute.
   
   Anyway, I have added support for feature model variables to the `feature-launcher-maven-plugin` in https://issues.apache.org/jira/browse/SLING-10420 and pushed changes which use that. The mongo port is now dynamic.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org