You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2021/02/03 23:24:02 UTC
[Impala-ASF-CR] IMPALA-10274: Initialize impala-python as part of the CMake build
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16607 )
Change subject: IMPALA-10274: Initialize impala-python as part of the CMake build
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/16607/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16607/4//COMMIT_MSG@19
PS4, Line 19: - Rebuilt and verified that impala-python is not reinitialized
> Are there any considerations about testing against different OS versions? I
Yes, for system python, Centos 7, Ubuntu 16, Ubuntu 18, and SLES 12 all use python 2.7 by default from what I can tell. For Centos 8, we set up python to point to python 2.7.
I verified this on Centos 7, which currently has the oldest python.
http://gerrit.cloudera.org:8080/#/c/16607/4/be/src/codegen/gen_ir_descriptions.py
File be/src/codegen/gen_ir_descriptions.py:
http://gerrit.cloudera.org:8080/#/c/16607/4/be/src/codegen/gen_ir_descriptions.py@1
PS4, Line 1: #!/usr/bin/env python
> Maybe comment why this doesn't use impala-python?
Done
http://gerrit.cloudera.org:8080/#/c/16607/4/bin/gen_build_version.py
File bin/gen_build_version.py:
http://gerrit.cloudera.org:8080/#/c/16607/4/bin/gen_build_version.py@1
PS4, Line 1: #!/usr/bin/env python
> Maybe comment why this doesn't use impala-python?
Done
--
To view, visit http://gerrit.cloudera.org:8080/16607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieff51263c55bd234028fed7101c94b4a928590f0
Gerrit-Change-Number: 16607
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Feb 2021 23:24:02 +0000
Gerrit-HasComments: Yes