[GitHub] [fineract] avikganguly01 commented on a change in pull request #1886: Feat: Node aware job scheduler

[GitBox <gi...@apache.org>]

avikganguly01 commented on a change in pull request #1886:
URL: https://github.com/apache/fineract/pull/1886#discussion_r725997469



##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/domain/ScheduledJobDetail.java
##########
@@ -135,6 +141,14 @@ public void updateJobKey(final String jobKey) {
         this.jobKey = jobKey;
     }
 
+    public boolean isDirtyJob() {
+        return this.isDirtyJob;

Review comment:
       I agree that dirty is not the right word for this.  This is when a manual job execution API call goes to the wrong node as part of load balancing and since this job runs on all nodes, it can trigger the flagged job at the right node. @BLasan : Can we add this as a comment if we don't have a more appropriate descriptive word for this. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org