You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by MysticRyuujin <gi...@git.apache.org> on 2017/08/01 19:21:05 UTC

[GitHub] incubator-guacamole-manual pull request #55: GUACAMOLE-357: Update Documenta...

GitHub user MysticRyuujin opened a pull request:

    https://github.com/apache/incubator-guacamole-manual/pull/55

    GUACAMOLE-357: Update Documentation for Ubuntu Specific Library

    On Ubuntu the libjpeg62-turbo-dev package is named libjpeg-turbo8-dev, the instructions don't make that clear, I'd like to update the documentation to reflect that distinction.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MysticRyuujin/incubator-guacamole-manual patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-guacamole-manual/pull/55.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #55
    
----
commit d92ed32e41f7029887e1206a1cd4ba57503066b8
Author: Chase Wright <my...@gmail.com>
Date:   2017-08-01T19:20:42Z

    GUACAMOLE-357: Update Documentation for Ubuntu Specific Library
    
    On Ubuntu the libjpeg62-turbo-dev package is named libjpeg-turbo8-dev, the instructions don't make that clear, I'd like to update the documentation to reflect that distinction.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-manual pull request #55: GUACAMOLE-357: Update Documenta...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-guacamole-manual/pull/55


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-manual pull request #55: GUACAMOLE-357: Update Documenta...

Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/incubator-guacamole-manual/pull/55#discussion_r131514761
  
    --- Diff: src/chapters/installing.xml ---
    @@ -136,10 +136,14 @@
                                             <colspec colname="c2" colnum="2" colwidth="1.0*"/>
                                             <tbody>
                                                 <row>
    -                                                <entry>Debian / Ubuntu package</entry>
    +                                                <entry>Debian package</entry>
                                                     <entry><package>libjpeg62-turbo-dev</package></entry>
                                                 </row>
                                                 <row>
    +                                                <entry>Ubuntu package</entry>
    +                                                <entry><package>libjpeg-turbo8-dev</package></entry>
    --- End diff --
    
    Ubuntu uses Debian as the basis of each of their releases, right? Are you sure that Debian vs. Ubuntu is the dividing line between `libjpeg62-turbo-dev` and `libjpeg-turbo8-dev`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---