You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/01/20 13:22:08 UTC
Review Request 55763: Remove hard coded smartsense Log Feeder config
from Log Search stack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55763/
-----------------------------------------------------------
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Bugs: AMBARI-19650
https://issues.apache.org/jira/browse/AMBARI-19650
Repository: ambari
Description
-------
hard coded smartsense logfeeder configs removed. It was not even used anyway.
In smartsense, a patch is ready to use the metadata patter (with adding hst-logsearch-conf.xml)
Diffs
-----
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 7f502d7
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hst.json.j2 33a41a6
Diff: https://reviews.apache.org/r/55763/diff/
Testing
-------
unit tests done.
Thanks,
Oliver Szabo
Re: Review Request 55763: Remove hard coded smartsense Log Feeder
config from Log Search stack
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55763/#review162419
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Jan. 20, 2017, 1:22 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55763/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 1:22 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-19650
> https://issues.apache.org/jira/browse/AMBARI-19650
>
>
> Repository: ambari
>
>
> Description
> -------
>
> hard coded smartsense logfeeder configs removed. It was not even used anyway.
> In smartsense, a patch is ready to use the metadata patter (with adding hst-logsearch-conf.xml)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 7f502d7
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hst.json.j2 33a41a6
>
> Diff: https://reviews.apache.org/r/55763/diff/
>
>
> Testing
> -------
>
> unit tests done.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 55763: Remove hard coded smartsense Log Feeder
config from Log Search stack
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55763/#review162426
-----------------------------------------------------------
Ship it!
Ship It!
- Miklos Gergely
On Jan. 20, 2017, 1:22 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55763/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 1:22 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-19650
> https://issues.apache.org/jira/browse/AMBARI-19650
>
>
> Repository: ambari
>
>
> Description
> -------
>
> hard coded smartsense logfeeder configs removed. It was not even used anyway.
> In smartsense, a patch is ready to use the metadata patter (with adding hst-logsearch-conf.xml)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 7f502d7
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hst.json.j2 33a41a6
>
> Diff: https://reviews.apache.org/r/55763/diff/
>
>
> Testing
> -------
>
> unit tests done.
>
>
> Thanks,
>
> Oliver Szabo
>
>