[GitHub] ctubbsii commented on issue #1050: Fix #871 Use regular jar for ITs module

[GitBox <gi...@apache.org>]

ctubbsii commented on issue #1050: Fix #871 Use regular jar for ITs module
URL: https://github.com/apache/fluo/pull/1050#issuecomment-425255883
 
 
   The fact that these issues were found only after moving tests from `src/test/java/` to `src/main/java/` indicates that checkstyle probably isn't checking for issues in our tests in other modules either. I think it should. I found at least one bug (failure to confirm that an expected exception was thrown) going through these and triaging them, and another one that could have easily become a bug (reuse of an existing TestTransaction variable). Running checkstyle to help triage potential issues in tests is just as important for ensuring our tests are high quality, as it is to ensure our main code is high quality.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services