You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/04 16:28:03 UTC
[GitHub] [dubbo-go] georgehao opened a new pull request #910: fix: fix router_config add &url to url
georgehao opened a new pull request #910:
URL: https://github.com/apache/dubbo-go/pull/910
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
fix bug
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #910: fix: fix router_config add &url to url
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #910:
URL: https://github.com/apache/dubbo-go/pull/910#issuecomment-738957946
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/910?src=pr&el=h1) Report
> Merging [#910](https://codecov.io/gh/apache/dubbo-go/pull/910?src=pr&el=desc) (8f916e6) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/7efba166a92cef97b043980169fe91b0c99bbfcd?el=desc) (7efba16) will **decrease** coverage by `0.10%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/910?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #910 +/- ##
===========================================
- Coverage 59.90% 59.79% -0.11%
===========================================
Files 260 260
Lines 12854 12854
===========================================
- Hits 7700 7686 -14
- Misses 4191 4206 +15
+ Partials 963 962 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/910?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/910/diff?src=pr&el=tree#diff-Y29uZmlnL3JvdXRlcl9jb25maWcuZ28=) | `68.18% <100.00%> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/910/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/910/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `29.66% <0.00%> (-9.33%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/910/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/910/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.31% <0.00%> (+2.40%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/910?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/910?src=pr&el=footer). Last update [7efba16...8f916e6](https://codecov.io/gh/apache/dubbo-go/pull/910?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx merged pull request #910: fix: fix router_config add &url to url
Posted by GitBox <gi...@apache.org>.
zouyx merged pull request #910:
URL: https://github.com/apache/dubbo-go/pull/910
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org