You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Ian Eure (JIRA)" <ji...@apache.org> on 2010/01/20 08:26:09 UTC
[jira] Created: (THRIFT-682) PHP extension doesn't compile on Mac
OS X
PHP extension doesn't compile on Mac OS X
-----------------------------------------
Key: THRIFT-682
URL: https://issues.apache.org/jira/browse/THRIFT-682
Project: Thrift
Issue Type: Improvement
Components: Library (PHP)
Affects Versions: 0.2
Environment: Mac OS X 10.6 Snow Leopard
Reporter: Ian Eure
Fix For: 0.2
The PHP Thrift extension doesn't compile on Mac OS X, because it's missing byteorder.h.
The attached patch works around this issue, but probably isn't the correct implementation. I imagine that it needs to be integrated into autoconf, but it gets the extension compiling for now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-682) PHP extension doesn't compile on Mac
OS X
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-682:
---------------------------------
Fix Version/s: 0.5
(was: 0.4)
I rolled this back in the 0.4.x branch since it seems to make things worse. I'll get it fixed in 0.5 with the help of THRIFT-851.
> PHP extension doesn't compile on Mac OS X
> -----------------------------------------
>
> Key: THRIFT-682
> URL: https://issues.apache.org/jira/browse/THRIFT-682
> Project: Thrift
> Issue Type: Improvement
> Components: Library (PHP)
> Affects Versions: 0.2
> Environment: Mac OS X 10.6 Snow Leopard
> Reporter: Ian Eure
> Assignee: Bryan Duxbury
> Fix For: 0.5
>
> Attachments: patch-src-php_thrift_protocol.cpp.diff, thrift-682-v2.patch
>
>
> The PHP Thrift extension doesn't compile on Mac OS X, because it's missing byteorder.h.
> The attached patch works around this issue, but probably isn't the correct implementation. I imagine that it needs to be integrated into autoconf, but it gets the extension compiling for now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-682) PHP extension doesn't compile on Mac OS
X
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-682.
--------------------------------
Assignee: Bryan Duxbury
Resolution: Fixed
I just committed the v2 version of the patch so I can get it into 0.4 release.
> PHP extension doesn't compile on Mac OS X
> -----------------------------------------
>
> Key: THRIFT-682
> URL: https://issues.apache.org/jira/browse/THRIFT-682
> Project: Thrift
> Issue Type: Improvement
> Components: Library (PHP)
> Affects Versions: 0.2
> Environment: Mac OS X 10.6 Snow Leopard
> Reporter: Ian Eure
> Assignee: Bryan Duxbury
> Fix For: 0.4
>
> Attachments: patch-src-php_thrift_protocol.cpp.diff, thrift-682-v2.patch
>
>
> The PHP Thrift extension doesn't compile on Mac OS X, because it's missing byteorder.h.
> The attached patch works around this issue, but probably isn't the correct implementation. I imagine that it needs to be integrated into autoconf, but it gets the extension compiling for now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-682) PHP extension doesn't compile on Mac
OS X
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-682:
---------------------------------
Attachment: thrift-682-v2.patch
How about this implementation?
> PHP extension doesn't compile on Mac OS X
> -----------------------------------------
>
> Key: THRIFT-682
> URL: https://issues.apache.org/jira/browse/THRIFT-682
> Project: Thrift
> Issue Type: Improvement
> Components: Library (PHP)
> Affects Versions: 0.2
> Environment: Mac OS X 10.6 Snow Leopard
> Reporter: Ian Eure
> Fix For: 0.4
>
> Attachments: patch-src-php_thrift_protocol.cpp.diff, thrift-682-v2.patch
>
>
> The PHP Thrift extension doesn't compile on Mac OS X, because it's missing byteorder.h.
> The attached patch works around this issue, but probably isn't the correct implementation. I imagine that it needs to be integrated into autoconf, but it gets the extension compiling for now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-682) PHP extension doesn't compile on Mac
OS X
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-682:
---------------------------------
Fix Version/s: 0.4
(was: 0.2)
> PHP extension doesn't compile on Mac OS X
> -----------------------------------------
>
> Key: THRIFT-682
> URL: https://issues.apache.org/jira/browse/THRIFT-682
> Project: Thrift
> Issue Type: Improvement
> Components: Library (PHP)
> Affects Versions: 0.2
> Environment: Mac OS X 10.6 Snow Leopard
> Reporter: Ian Eure
> Fix For: 0.4
>
> Attachments: patch-src-php_thrift_protocol.cpp.diff
>
>
> The PHP Thrift extension doesn't compile on Mac OS X, because it's missing byteorder.h.
> The attached patch works around this issue, but probably isn't the correct implementation. I imagine that it needs to be integrated into autoconf, but it gets the extension compiling for now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-682) PHP extension doesn't compile on Mac
OS X
Posted by "Ian Eure (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Eure updated THRIFT-682:
----------------------------
Attachment: patch-src-php_thrift_protocol.cpp.diff
I found the implementation via Google, didn't write it myself, so I can't grant any license.
Perhaps someone can come up with a better patch.
> PHP extension doesn't compile on Mac OS X
> -----------------------------------------
>
> Key: THRIFT-682
> URL: https://issues.apache.org/jira/browse/THRIFT-682
> Project: Thrift
> Issue Type: Improvement
> Components: Library (PHP)
> Affects Versions: 0.2
> Environment: Mac OS X 10.6 Snow Leopard
> Reporter: Ian Eure
> Fix For: 0.2
>
> Attachments: patch-src-php_thrift_protocol.cpp.diff
>
>
> The PHP Thrift extension doesn't compile on Mac OS X, because it's missing byteorder.h.
> The attached patch works around this issue, but probably isn't the correct implementation. I imagine that it needs to be integrated into autoconf, but it gets the extension compiling for now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.