[GitHub] [superset] AAfghahi commented on a diff in pull request #22136: feat: Flow for tables that already have a dataset

[GitBox <gi...@apache.org>]

AAfghahi commented on code in PR #22136:
URL: https://github.com/apache/superset/pull/22136#discussion_r1029452626


##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/DatasetPanel.tsx:
##########
@@ -168,15 +202,52 @@ export interface IDatasetPanelProps {
    * Boolean indicating if the component is in a loading state
    */
   loading: boolean;
+  datasets?: DatasetObject[] | undefined;

Review Comment:
   nit: I kind of want this to have a better name, maybe existingDatasets? or something along those lines.



##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/DatasetPanel.tsx:
##########
@@ -168,15 +202,52 @@ export interface IDatasetPanelProps {
    * Boolean indicating if the component is in a loading state
    */
   loading: boolean;
+  datasets?: DatasetObject[] | undefined;
 }
 
+const EXISTING_DATASET_DESCRIPTION = t(
+  'You can only associate one dataset with one table. This table already has a dataset associated with it in Preset.\n',

Review Comment:
   Hmm, does this need to be preset specific language? If so, then I think we need to add that in on the Preset side and have a more generic description in superset. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org