[GitHub] DaanHoogland commented on a change in pull request #1709: CLOUDSTACK-7982: KVM live migration with local storage

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #1709: CLOUDSTACK-7982: KVM live migration with local storage
URL: https://github.com/apache/cloudstack/pull/1709#discussion_r155556899
 
 

 ##########
 File path: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
 ##########
 @@ -1104,6 +1091,14 @@ public void prepareForMigration(VirtualMachineProfile vm, DeployDestination dest
             disk.setDetails(getDetails(volumeInfo, dataStore));
 
             vm.addDisk(disk);
+
+            // Ensure that the template is available on the destination host
+            if (vm.getType() == VirtualMachine.Type.User && vol.getVolumeType().equals(Type.ROOT)) {
+                VMTemplateVO vmTemplate = _tmpltDao.findById(vol.getTemplateId());
+                StoragePool destStoragePool = storageMgr.findLocalStorageOnHost(dest.getHost().getId());
 
 Review comment:
   so this is where we need to extend if we want to make this work for shared storage as well.
   In fact findLocalStorageOnHost assumes StoragePoolType.LVM (the most likely candidate) while even localstorage has more types.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services