[GitHub] [ignite] nizhikov commented on a diff in pull request #10478: IGNITE-18533 Management API to kill client connection

[GitBox <gi...@apache.org>]

nizhikov commented on code in PR #10478:
URL: https://github.com/apache/ignite/pull/10478#discussion_r1069152269


##########
modules/control-utility/src/test/java/org/apache/ignite/util/KillCommandsControlShTest.java:
##########
@@ -153,6 +154,18 @@ public void testCancelContinuousQuery() throws Exception {
         });
     }
 
+    /** @throws Exception If failed. */
+    @Test
+    public void testCancelClientConnection() {
+        doTestCancelClientConnection(srvs, connId -> {
+            String nodeId = srvs.get(0).localNode().id().toString();
+
+            int res = execute("--kill", "client", "--node-id", nodeId, connId == null ? "ALL" : Long.toString(connId));

Review Comment:
   > Should command failed if connection wasn't dropped
   
   Yes. Fixed.
   
   > Let's add test for specific node id also
   
   Added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org