You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/03/24 15:53:20 UTC

[GitHub] [commons-bcel] garydgregory commented on a change in pull request #118: Force unsigned short for LineNumber.toString()

garydgregory commented on a change in pull request #118:
URL: https://github.com/apache/commons-bcel/pull/118#discussion_r834465818



##########
File path: src/test/java/org/apache/bcel/PLSETestCase.java
##########
@@ -116,6 +119,25 @@ public void testB295() throws Exception
         assertEquals(lv.getLength(), new_lv.getLength(), "live range length");
     }
 
+    /**
+     * BCEL-361: LineNumber.toString() treats code offset as signed
+     */
+    @Test
+    public void testB361() throws Exception
+    {
+        final JavaClass clazz = getTestClass(PACKAGE_BASE_NAME+".data.LargeMethod");

Review comment:
       Missing spaces around `+`. I'm on vacation but there is a test I want to run... back in a while...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org