You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/08/16 01:45:14 UTC
[jira] Created: (CASSANDRA-369) Expose commitlog queue size
Expose commitlog queue size
---------------------------
Key: CASSANDRA-369
URL: https://issues.apache.org/jira/browse/CASSANDRA-369
Project: Cassandra
Issue Type: New Feature
Reporter: Jonathan Ellis
Fix For: 0.4
Need to expose queue size of CommitLogExecutorService via jmx. Probably we can extract the mbean code from DebuggableThreadPoolExecutor and reuse it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-369) Expose commitlog queue size
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-369:
-------------------------------------
Attachment: 369.patch
adds getPendingTasks to CLES
> Expose commitlog queue size
> ---------------------------
>
> Key: CASSANDRA-369
> URL: https://issues.apache.org/jira/browse/CASSANDRA-369
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 369.patch
>
>
> Need to expose queue size of CommitLogExecutorService via jmx. Probably we can extract the mbean code from DebuggableThreadPoolExecutor and reuse it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-369) Expose commitlog queue size
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745434#action_12745434 ]
Hudson commented on CASSANDRA-369:
----------------------------------
Integrated in Cassandra #173 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/173/])
add getPendingTasks to CommitLogExecutorService
patch by jbellis; reviewed by Michael Greene for
> Expose commitlog queue size
> ---------------------------
>
> Key: CASSANDRA-369
> URL: https://issues.apache.org/jira/browse/CASSANDRA-369
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 369-v2.patch, 369.patch
>
>
> Need to expose queue size of CommitLogExecutorService via jmx. Probably we can extract the mbean code from DebuggableThreadPoolExecutor and reuse it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-369) Expose commitlog queue size
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745090#action_12745090 ]
Johan Oskarsson commented on CASSANDRA-369:
-------------------------------------------
Most other Apache projects I have worked with remove the author tags completely to make the code feel more community owned and encourage others to dare to touch it.
> Expose commitlog queue size
> ---------------------------
>
> Key: CASSANDRA-369
> URL: https://issues.apache.org/jira/browse/CASSANDRA-369
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 369-v2.patch, 369.patch
>
>
> Need to expose queue size of CommitLogExecutorService via jmx. Probably we can extract the mbean code from DebuggableThreadPoolExecutor and reuse it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-369) Expose commitlog queue size
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-369:
----------------------------------------
Assignee: Jonathan Ellis
> Expose commitlog queue size
> ---------------------------
>
> Key: CASSANDRA-369
> URL: https://issues.apache.org/jira/browse/CASSANDRA-369
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 369.patch
>
>
> Need to expose queue size of CommitLogExecutorService via jmx. Probably we can extract the mbean code from DebuggableThreadPoolExecutor and reuse it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-369) Expose commitlog queue size
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745099#action_12745099 ]
Jonathan Ellis commented on CASSANDRA-369:
------------------------------------------
+1 for removing wholesale
> Expose commitlog queue size
> ---------------------------
>
> Key: CASSANDRA-369
> URL: https://issues.apache.org/jira/browse/CASSANDRA-369
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 369-v2.patch, 369.patch
>
>
> Need to expose queue size of CommitLogExecutorService via jmx. Probably we can extract the mbean code from DebuggableThreadPoolExecutor and reuse it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-369) Expose commitlog queue size
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745209#action_12745209 ]
Jonathan Ellis commented on CASSANDRA-369:
------------------------------------------
mbeans are kinda retarded, if you don't name the interface <classname>MBean then it gets all confused. it will build, but then it will puke all over at runtime. :(
> Expose commitlog queue size
> ---------------------------
>
> Key: CASSANDRA-369
> URL: https://issues.apache.org/jira/browse/CASSANDRA-369
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 369-v2.patch, 369.patch
>
>
> Need to expose queue size of CommitLogExecutorService via jmx. Probably we can extract the mbean code from DebuggableThreadPoolExecutor and reuse it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-369) Expose commitlog queue size
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-369:
-------------------------------------
Attachment: 369-v2.patch
better patch.
> Expose commitlog queue size
> ---------------------------
>
> Key: CASSANDRA-369
> URL: https://issues.apache.org/jira/browse/CASSANDRA-369
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 369-v2.patch, 369.patch
>
>
> Need to expose queue size of CommitLogExecutorService via jmx. Probably we can extract the mbean code from DebuggableThreadPoolExecutor and reuse it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-369) Expose commitlog queue size
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745283#action_12745283 ]
Michael Greene commented on CASSANDRA-369:
------------------------------------------
The code looks good after explanation and works when exercised. I was surprised that running stress against against a single node cluster, probing that node only ever gives values of 0,1, or 2 for the commitlog--it seems like it should have a deeper queue then that.
+1
> Expose commitlog queue size
> ---------------------------
>
> Key: CASSANDRA-369
> URL: https://issues.apache.org/jira/browse/CASSANDRA-369
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 369-v2.patch, 369.patch
>
>
> Need to expose queue size of CommitLogExecutorService via jmx. Probably we can extract the mbean code from DebuggableThreadPoolExecutor and reuse it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-369) Expose commitlog queue size
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745087#action_12745087 ]
Michael Greene commented on CASSANDRA-369:
------------------------------------------
Do we have a policy on author tags? Should we be getting rid of them wholesale instead of mucking up changesets?
> Expose commitlog queue size
> ---------------------------
>
> Key: CASSANDRA-369
> URL: https://issues.apache.org/jira/browse/CASSANDRA-369
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 369-v2.patch, 369.patch
>
>
> Need to expose queue size of CommitLogExecutorService via jmx. Probably we can extract the mbean code from DebuggableThreadPoolExecutor and reuse it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-369) Expose commitlog queue size
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744776#action_12744776 ]
Jonathan Ellis commented on CASSANDRA-369:
------------------------------------------
oops, bad patch.
> Expose commitlog queue size
> ---------------------------
>
> Key: CASSANDRA-369
> URL: https://issues.apache.org/jira/browse/CASSANDRA-369
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 369.patch
>
>
> Need to expose queue size of CommitLogExecutorService via jmx. Probably we can extract the mbean code from DebuggableThreadPoolExecutor and reuse it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-369) Expose commitlog queue size
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-369:
-------------------------------------
Component/s: Tools
> Expose commitlog queue size
> ---------------------------
>
> Key: CASSANDRA-369
> URL: https://issues.apache.org/jira/browse/CASSANDRA-369
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
>
> Need to expose queue size of CommitLogExecutorService via jmx. Probably we can extract the mbean code from DebuggableThreadPoolExecutor and reuse it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-369) Expose commitlog queue size
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745206#action_12745206 ]
Michael Greene commented on CASSANDRA-369:
------------------------------------------
What's the point of keeping DebuggableThreadPoolExecutorMBean around?
> Expose commitlog queue size
> ---------------------------
>
> Key: CASSANDRA-369
> URL: https://issues.apache.org/jira/browse/CASSANDRA-369
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 369-v2.patch, 369.patch
>
>
> Need to expose queue size of CommitLogExecutorService via jmx. Probably we can extract the mbean code from DebuggableThreadPoolExecutor and reuse it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.