You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/08 04:07:50 UTC

[GitHub] [flink] jiasheng55 opened a new pull request #10793: [FLINK-15448][runtime] Log host informations for TaskManager failures.

jiasheng55 opened a new pull request #10793: [FLINK-15448][runtime] Log host informations for TaskManager failures.
URL: https://github.com/apache/flink/pull/10793
 
 
   
   ## What is the purpose of the change
   
   To provide host information in case of TaskManager failures, so users could find the log file more conveniently.
   
   ## Brief change log
   
     - Add host information when logging TaskManager failures. 
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: ( no )
     - The runtime per-record code paths (performance sensitive): ( no )
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no )
     - The S3 file system connector: ( no )
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10793: [FLINK-15448][runtime] Log host informations for TaskManager failures.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10793: [FLINK-15448][runtime] Log host informations for TaskManager failures.
URL: https://github.com/apache/flink/pull/10793#issuecomment-571883383
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 90d0c8a912cf192d1eb1c5e94cb48b4967790ca9 (Wed Jan 08 04:10:46 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] jiasheng55 commented on issue #10793: [FLINK-15448][runtime] Log host informations for TaskManager failures.

Posted by GitBox <gi...@apache.org>.
jiasheng55 commented on issue #10793: [FLINK-15448][runtime] Log host informations for TaskManager failures.
URL: https://github.com/apache/flink/pull/10793#issuecomment-571883867
 
 
   Didn't catch up with the latest discussion, closing this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] jiasheng55 closed pull request #10793: [FLINK-15448][runtime] Log host informations for TaskManager failures.

Posted by GitBox <gi...@apache.org>.
jiasheng55 closed pull request #10793: [FLINK-15448][runtime] Log host informations for TaskManager failures.
URL: https://github.com/apache/flink/pull/10793
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services