You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/04/21 21:03:33 UTC
[GitHub] [helix] narendly opened a new pull request #1705: Disable CORS by default in Helix REST
narendly opened a new pull request #1705:
URL: https://github.com/apache/helix/pull/1705
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Fixes #1704
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
CORS headers won't be included by default. If the REST admin wants to enable CORS, then they can do so by setting the boolean flag in System.Properties.
### Tests
- [ ] The following tests are written for this issue:
Will be tested manually.
- The following is the result of the "mvn test" command on the appropriate module:
[INFO] Tests run: 173, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 244.489 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 173, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 04:14 min
[INFO] Finished at: 2021-04-21T14:02:23-07:00
[INFO] ------------------------------------------------------------------------
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on pull request #1705: Disable CORS by default in Helix REST
Posted by GitBox <gi...@apache.org>.
narendly commented on pull request #1705:
URL: https://github.com/apache/helix/pull/1705#issuecomment-825945044
This PR is ready to be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] dasahcc commented on a change in pull request #1705: Disable CORS by default in Helix REST
Posted by GitBox <gi...@apache.org>.
dasahcc commented on a change in pull request #1705:
URL: https://github.com/apache/helix/pull/1705#discussion_r617976935
##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/HelixRestServer.java
##########
@@ -164,7 +165,10 @@ protected ResourceConfig getResourceConfig(HelixRestNamespace namespace, Servlet
}
cfg.property(ContextPropertyKeys.METADATA.name(), namespace);
- cfg.register(new CORSFilter());
+ if (Boolean.getBoolean(CORS_ENABLED)) {
Review comment:
Are you trying to get it from the system property? This always give you false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly merged pull request #1705: Disable CORS by default in Helix REST
Posted by GitBox <gi...@apache.org>.
narendly merged pull request #1705:
URL: https://github.com/apache/helix/pull/1705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on a change in pull request #1705: Disable CORS by default in Helix REST
Posted by GitBox <gi...@apache.org>.
narendly commented on a change in pull request #1705:
URL: https://github.com/apache/helix/pull/1705#discussion_r618953987
##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/HelixRestServer.java
##########
@@ -164,7 +165,10 @@ protected ResourceConfig getResourceConfig(HelixRestNamespace namespace, Servlet
}
cfg.property(ContextPropertyKeys.METADATA.name(), namespace);
- cfg.register(new CORSFilter());
+ if (Boolean.getBoolean(CORS_ENABLED)) {
Review comment:
https://docs.oracle.com/javase/8/docs/api/java/lang/Boolean.html#getBoolean-java.lang.String-
It gets it from System Properties by the string key provided. So if the key-value pair is defined in System.Properties, this will evaluate to `true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org