You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/03/10 02:46:18 UTC
[GitHub] [incubator-apisix-dashboard] juzhiyuan opened a new issue #136:
Complete the License information for the next dashboard
juzhiyuan opened a new issue #136: Complete the License information for the next dashboard
URL: https://github.com/apache/incubator-apisix-dashboard/issues/136
We are building the next dashboard based on Ant Design Pro, which is an Open Source project for building awesome dashboard. We need your help to add the License header to the following files under `next` branch, just like [1], but be carefully, we should use [2] this one instead. Please send a PR once you complete this issue.
Files need to add License header:
**TODO:**
[1] https://github.com/apache/incubator-apisix-dashboard/blob/b3045dd2021e50d7d9943f22aae6ca7e080a15b8/src/views/login/index.vue#L1
[2] https://github.com/ant-design/ant-design-pro/blob/master/LICENSE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #136:
Complete the License information for the next dashboard
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #136: Complete the License information for the next dashboard
URL: https://github.com/apache/incubator-apisix-dashboard/issues/136#issuecomment-596873543
@moonming The dashboard boilerplate is under MIT License, I'm not sure if we need add MIT License to them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan edited a comment on issue
#136: Complete the License information for the next dashboard
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #136: Complete the License information for the next dashboard
URL: https://github.com/apache/incubator-apisix-dashboard/issues/136#issuecomment-600463002
Please take a look at https://github.com/apache/incubator-apisix-dashboard/issues/136#issue-578300848
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #136:
Complete the License information for the next dashboard
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #136: Complete the License information for the next dashboard
URL: https://github.com/apache/incubator-apisix-dashboard/issues/136#issuecomment-596876112
Just for sure, which files should add the MIT header? We would use nearly all of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] jayasithu commented on issue #136:
Complete the License information for the next dashboard
Posted by GitBox <gi...@apache.org>.
jayasithu commented on issue #136: Complete the License information for the next dashboard
URL: https://github.com/apache/incubator-apisix-dashboard/issues/136#issuecomment-600442453
Hi I would like to contribute to this. How can I get started
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] moonming commented on issue #136:
Complete the License information for the next dashboard
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #136: Complete the License information for the next dashboard
URL: https://github.com/apache/incubator-apisix-dashboard/issues/136#issuecomment-596875098
yes, we need add the license for it.
Thanks,
Ming Wen
Twitter: _WenMing
琚致远 <no...@github.com> 于2020年3月10日周二 上午10:47写道：
> @moonming <https://github.com/moonming> The dashboard boilerplate is
> under MIT License, I'm not sure if we need add MIT License to them?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-apisix-dashboard/issues/136?email_source=notifications&email_token=AGJZBKZLSOC4PF5GP7QGIGDRGWS3XA5CNFSM4LEVSWJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOJZCRY#issuecomment-596873543>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGJZBK36DSAUDALKIP7K2BTRGWS3XANCNFSM4LEVSWJA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] moonming commented on issue #136:
Complete the License information for the next dashboard
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #136: Complete the License information for the next dashboard
URL: https://github.com/apache/incubator-apisix-dashboard/issues/136#issuecomment-596877043
here is a example:
https://github.com/apache/incubator-apisix-dashboard/blob/master/LICENSE#L205
Thanks,
Ming Wen
Twitter: _WenMing
琚致远 <no...@github.com> 于2020年3月10日周二 上午10:57写道：
> Just for sure, which files should add the MIT header? We would use nearly
> all of them.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-apisix-dashboard/issues/136?email_source=notifications&email_token=AGJZBK7S5ATH4C47DACHBX3RGWUDHA5CNFSM4LEVSWJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOJZWUA#issuecomment-596876112>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGJZBK4PZMPDWZ373KXC653RGWUDHANCNFSM4LEVSWJA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan edited a comment on issue
#136: Complete the License information for the next dashboard
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #136: Complete the License information for the next dashboard
URL: https://github.com/apache/incubator-apisix-dashboard/issues/136#issuecomment-600463002
Please take a llok at https://github.com/apache/incubator-apisix-dashboard/issues/136#issue-578300848
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #136:
Complete the License information for the next dashboard
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #136: Complete the License information for the next dashboard
URL: https://github.com/apache/incubator-apisix-dashboard/issues/136#issuecomment-596886881
@moonming Just updated the issue#1, please take a look when you are free.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] moonming commented on issue #136:
Complete the License information for the next dashboard
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #136: Complete the License information for the next dashboard
URL: https://github.com/apache/incubator-apisix-dashboard/issues/136#issuecomment-596877880
yes, you are right.
Thanks,
Ming Wen
Twitter: _WenMing
琚致远 <no...@github.com> 于2020年3月10日周二 上午11:04写道：
> Oh I see, so we don't have to add MIT header for every file under next
> branch? Just add the License line in LICENSE file?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-apisix-dashboard/issues/136?email_source=notifications&email_token=AGJZBK2SXKSZVSCKX5QQEMDRGWU3VA5CNFSM4LEVSWJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOJ2DFA#issuecomment-596877716>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGJZBKZZ43DF5RLREYEWUD3RGWU3VANCNFSM4LEVSWJA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #136:
Complete the License information for the next dashboard
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #136: Complete the License information for the next dashboard
URL: https://github.com/apache/incubator-apisix-dashboard/issues/136#issuecomment-600463002
Please refer https://github.com/apache/incubator-apisix-dashboard/issues/136#issue-578300848
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #136:
Complete the License information for the next dashboard
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #136: Complete the License information for the next dashboard
URL: https://github.com/apache/incubator-apisix-dashboard/issues/136#issuecomment-596877716
Oh I see, so we don't have to add MIT header for every file under `next` branch? Just add the License line in `LICENSE` file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services