You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/29 20:48:14 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request, #2384: Allow CTEs to be referenced from subquery expressions
andygrove opened a new pull request, #2384:
URL: https://github.com/apache/arrow-datafusion/pull/2384
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes https://github.com/apache/arrow-datafusion/issues/2379
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Allows CTEs fo be referenced from subqueries.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- Propagate CTEs through to more of the SQL planner
- Changed `outer_query_schema` so that it is not an `Option` and now includes all CTE schemas
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #2384: Allow CTEs to be referenced from subquery expressions
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #2384:
URL: https://github.com/apache/arrow-datafusion/pull/2384#discussion_r862409579
##########
datafusion/common/src/dfschema.rs:
##########
@@ -133,18 +133,22 @@ impl DFSchema {
/// Modify this schema by appending the fields from the supplied schema, ignoring any
/// duplicate fields.
pub fn merge(&mut self, other_schema: &DFSchema) {
- for field in other_schema.fields() {
- // skip duplicate columns
- let duplicated_field = match field.qualifier() {
- Some(q) => self.field_with_name(Some(q.as_str()), field.name()).is_ok(),
- // for unqualifed columns, check as unqualified name
- None => self.field_with_unqualified_name(field.name()).is_ok(),
- };
- if !duplicated_field {
- self.fields.push(field.clone());
+ if !other_schema.fields.is_empty() {
Review Comment:
Thanks for the review @yjshen. I made that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yjshen commented on a diff in pull request #2384: Allow CTEs to be referenced from subquery expressions
Posted by GitBox <gi...@apache.org>.
yjshen commented on code in PR #2384:
URL: https://github.com/apache/arrow-datafusion/pull/2384#discussion_r862408152
##########
datafusion/common/src/dfschema.rs:
##########
@@ -133,18 +133,22 @@ impl DFSchema {
/// Modify this schema by appending the fields from the supplied schema, ignoring any
/// duplicate fields.
pub fn merge(&mut self, other_schema: &DFSchema) {
- for field in other_schema.fields() {
- // skip duplicate columns
- let duplicated_field = match field.qualifier() {
- Some(q) => self.field_with_name(Some(q.as_str()), field.name()).is_ok(),
- // for unqualifed columns, check as unqualified name
- None => self.field_with_unqualified_name(field.name()).is_ok(),
- };
- if !duplicated_field {
- self.fields.push(field.clone());
+ if !other_schema.fields.is_empty() {
Review Comment:
An earlier return might be cleaner?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #2384: Allow CTEs to be referenced from subquery expressions
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #2384:
URL: https://github.com/apache/arrow-datafusion/pull/2384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org