You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/04/26 11:44:26 UTC
[GitHub] [iceberg] Fokko opened a new issue, #7437: Python: Replace MockCatalog with InMemoryCatalog
Fokko opened a new issue, #7437:
URL: https://github.com/apache/iceberg/issues/7437
### Feature Request / Improvement
We have two Catalogs in test, I think it would be good to merge them to avoid having duplicate/similar code.
### Query engine
Other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko closed issue #7437: Python: Replace MockCatalog with InMemoryCatalog
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko closed issue #7437: Python: Replace MockCatalog with InMemoryCatalog
URL: https://github.com/apache/iceberg/issues/7437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] DarthData410 commented on issue #7437: Python: Replace MockCatalog with InMemoryCatalog
Posted by "DarthData410 (via GitHub)" <gi...@apache.org>.
DarthData410 commented on issue #7437:
URL: https://github.com/apache/iceberg/issues/7437#issuecomment-1528821400
Hey @Fokko I reviewed the code within the test *.py files. The InMemoryCatalog can be found @: https://github.com/apache/iceberg/blob/251c9fa796157b06fc89e18fbb9a43045f459b07/python/tests/catalog/test_base.py#L52
While the only reference I found to MockCatalog (as-typed) is @: https://github.com/apache/iceberg/blob/251c9fa796157b06fc89e18fbb9a43045f459b07/python/tests/cli/test_console.py#L103
With this in mind, would you like to see the /python/test/cli/test_console.py updated so that the MockCatalog is inherited from InMemoryCatalog found in test_base.py? Since they both inherit from Catalog class? Further, would InMemoryCatalog remain housed in test_base.py and have this imported from test_console.py? Or a new python file called test_catalogs.py (for example) created in /python/test/catalog/ to be imported from and used?
Another option is the removal of reference to MockCatalog in test, and just reference InMemoryCatalog, but again would need to either have it imported from test_base.py or moved to its own python file to imported from.
Either way I can complete this scope of work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org