You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltacloud.apache.org by mf...@redhat.com on 2012/02/24 13:23:19 UTC

[PATCH core 3/3] RHEV-M: Report 404 correctly on unknown datacenter

From: Michal Fojtik <mf...@redhat.com>


Signed-off-by: Michal fojtik <mf...@redhat.com>
---
 .../lib/deltacloud/drivers/rhevm/rhevm_driver.rb   |   12 ++++--------
 1 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb b/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
index 162175c..10ffef3 100644
--- a/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
+++ b/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
@@ -335,20 +335,16 @@ class RHEVMDriver < Deltacloud::BaseDriver
       status 401
     end
 
-    on /ResourceNotFound/ do
-      status 404
-    end
-
     on /(InternalServerError|nodename nor servname provided)/ do
       status 502
     end
 
-    on /(RestClient|RHEVM|Ovirt)/ do
-      status 500
+    on /(404|ResourceNotFound)/ do
+      status 404
     end
 
-    on /(.*) not found^/ do
-      status 400
+    on /(RestClient|RHEVM|OVIRT)/ do
+      status 500
     end
 
     on /Parameter name/ do
-- 
1.7.9.1


Re: [PATCH core 3/3] RHEV-M: Report 404 correctly on unknown datacenter

Posted by Francesco Vollero <fv...@redhat.com>.
Ack'd

Cheers,
Francesco

On Fri, Feb 24, 2012 at 01:23:19PM +0100, mfojtik@redhat.com wrote:
> From: Michal Fojtik <mf...@redhat.com>
> 
> 
> Signed-off-by: Michal fojtik <mf...@redhat.com>
> ---
>  .../lib/deltacloud/drivers/rhevm/rhevm_driver.rb   |   12 ++++--------
>  1 files changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb b/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
> index 162175c..10ffef3 100644
> --- a/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
> +++ b/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
> @@ -335,20 +335,16 @@ class RHEVMDriver < Deltacloud::BaseDriver
>        status 401
>      end
>  
> -    on /ResourceNotFound/ do
> -      status 404
> -    end
> -
>      on /(InternalServerError|nodename nor servname provided)/ do
>        status 502
>      end
>  
> -    on /(RestClient|RHEVM|Ovirt)/ do
> -      status 500
> +    on /(404|ResourceNotFound)/ do
> +      status 404
>      end
>  
> -    on /(.*) not found^/ do
> -      status 400
> +    on /(RestClient|RHEVM|OVIRT)/ do
> +      status 500
>      end
>  
>      on /Parameter name/ do
> -- 
> 1.7.9.1
>