You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/03/02 05:50:40 UTC
[GitHub] xinyu-intel opened a new pull request #9958: Parallelization for ROIpooling OP
xinyu-intel opened a new pull request #9958: Parallelization for ROIpooling OP
URL: https://github.com/apache/incubator-mxnet/pull/9958
## Description ##
**What's the problem?**
ROIpooling is used in the Faster-RCNN. It will consume lots of time in the inference path because of the current implementation [(here)](https://github.com/apache/incubator-mxnet/blob/master/src/operator/roi_pooling.cc
) is not parallelized.
One profiling results as below:
Time of each OP: | ms | ms/call | calls
-- | -- | -- | --
ROIPooling | **38718.288** | 1548.73152 | 25
Convolution | 9963.628 | 3.724720748 | 2675
Reshape | 0.677 | 0.00677 | 100
Activation | 1089.6 | 0.427294118 | 2550
SoftmaxActivation | 43.279 | 1.73116 | 25
add_n | 1664.403 | 2.017458182 | 825
Pooling | 68.531 | 1.37062 | 50
_contrib_Proposal | 351.051 | 14.04204 | 25
softmax | 0.658 | 0.02632 | 25
FullyConnected | 29.328 | 0.58656 | 50
BatchNorm | 2865.261 | 1.123631765 | 2550
**What we have tried**
We @pengzhao-intel @TaoLv have parallelized this pooling algorithm and got the 20+X performance improvement by OpenMP directives.
## Checklist ##
### Essentials ###
- [x] Passed code style checking (`make lint`)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [x] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [x] Parallelization for ROIpooling
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services