[PR] FLINK-36551: [OLM] ensure that docker-entry.sh actually replaces the keystore pod volume [flink-kubernetes-operator]

["k-wall (via GitHub)" <gi...@apache.org>]

k-wall opened a new pull request, #903:
URL: https://github.com/apache/flink-kubernetes-operator/pull/903

   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix][docs] Fix typo in event time introduction` or `[hotfix][javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can read more on how we use GitHub Actions for CI [here](https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-main/docs/development/guide/#cicd).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   This pull request fixes a defect in `tools/olm/docker_entry.sh`.  In order for Flink Kubernetes Operator to function under OLM the it utilises a serving certificate provided by OLM.  docker_entry.sh rewrites the deployment to allow this substitution to occur.  Unfortunate docker_entry.sh makes an assumption about the index of the `keystore` volume within the deployment.  The index has changed over time, meaning  docker_entry.sh replaces the wrong entry.
   
   ## Brief change log
   
   - [OLM] Fix indexing error when replacing the `keystore` volume within CSV. 
   - 
   ## Verifying this change
   
   I manually verified the change, firstly by ensuring the `yq` command was having the right effect and secondly by generating a OLM using `generate-olm-bundle.sh`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changes to the `CustomResourceDescriptors`: no
     - Core observer or reconciler logic that is regularly executed: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FLINK-36551: [OLM] ensure that docker-entry.sh actually replaces the keystore pod volume [flink-kubernetes-operator]

["gyfora (via GitHub)" <gi...@apache.org>]

gyfora merged PR #903:
URL: https://github.com/apache/flink-kubernetes-operator/pull/903


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org