You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/08/17 22:10:45 UTC
[jira] [Commented] (CB-8836) Crashes after animating splashscreen
[ https://issues.apache.org/jira/browse/CB-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14700147#comment-14700147 ]
ASF GitHub Bot commented on CB-8836:
------------------------------------
Github user idpaterson commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/56#issuecomment-131946308
The `dispatch_async` calls were added [here](https://github.com/apache/cordova-plugin-splashscreen/commit/559b300d29ba6eb2f951eb19b9bbf7ba9238a862) and reports on the commit of fading no longer working were disregarded. Further discussion on [the original issue](https://issues.apache.org/jira/browse/CB-8836) noted that the `dispatch_async` calls did not fully resolve whatever crash was being experienced.
Certainly removing these calls outright is not a complete solution since it disregards the earlier problem of crashes due to operating off the main thread, but this pull request thus far identifies that changes in the animation block must be synchronous in order to actually animate.
The related issue in Jira for fading no longer working on iOS is [CB-8875](https://issues.apache.org/jira/browse/CB-8875) for which there is an outstanding pull request #44 by @chrskrchr. This is a better but possibly not a complete solution either since the calls to `destroyViews` and `createViews` should probably also only be called on the main thread.
> Crashes after animating splashscreen
> ------------------------------------
>
> Key: CB-8836
> URL: https://issues.apache.org/jira/browse/CB-8836
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin SplashScreen
> Environment: iOS
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Attachments: CRASH LOG 1, CRASH LOG 2
>
>
> Discussion in https://github.com/apache/cordova-plugin-splashscreen/pull/21
> Fix here: https://gist.github.com/shazron/e45705f76bef4448139a/e6e1820943197e48fd6baf44b765ebdea0252b04
> Affected lines:
> https://github.com/apache/cordova-plugin-splashscreen/blob/35272415d3b75440b1ea5fe9a5baab5e1586b3c1/src/ios/CDVSplashScreen.m#L292-L304
> Crash causes:
> 1. retain cycle problem on self in the block
> 2. performing UIKit operations while not in the main thread.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org