You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jack Krupansky (JIRA)" <ji...@apache.org> on 2013/07/22 02:20:49 UTC

[jira] [Commented] (SOLR-4586) Increase default maxBooleanClauses

    [ https://issues.apache.org/jira/browse/SOLR-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714848#comment-13714848 ] 

Jack Krupansky commented on SOLR-4586:
--------------------------------------

Huh... I though we had settled this for 4.4. Oh well.

My latest thoughts.

1. For BooleanQuery, remove it. People writing or generating Solr queries are very aware when they are doing something big.

2. For "rewrite" of queries, have a warning and cutoff of the generated terms, rather than a hard fail. With FSTs, do we still have a rewriting problem?

3. Any query that can generate lots of terms should have an additional constructor parameter to specify the limit, or -1 if unlimited. No more global limit. Each query parser should have a "term expansion limit" parameter.

4. The default for the "term expansion limit" parameter should be expanded as hardware capabilities expand. Say 10,000 for a proposed Lucene limit and Solr config default limit as well.


                
> Increase default maxBooleanClauses
> ----------------------------------
>
>                 Key: SOLR-4586
>                 URL: https://issues.apache.org/jira/browse/SOLR-4586
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.2
>         Environment: 4.3-SNAPSHOT 1456767M - ncindex - 2013-03-15 13:11:50
>            Reporter: Shawn Heisey
>         Attachments: SOLR-4586.patch, SOLR-4586.patch, SOLR-4586.patch, SOLR-4586.patch, SOLR-4586.patch, SOLR-4586_verify_maxClauses.patch
>
>
> In the #solr IRC channel, I mentioned the maxBooleanClauses limitation to someone asking a question about queries.  Mark Miller told me that maxBooleanClauses no longer applies, that the limitation was removed from Lucene sometime in the 3.x series.  The config still shows up in the example even in the just-released 4.2.
> Checking through the source code, I found that the config option is parsed and the value stored in objects, but does not actually seem to be used by anything.  I removed every trace of it that I could find, and all tests still pass.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org