You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2022/09/22 08:41:17 UTC

[GitHub] [phoenix] Aarchy commented on a diff in pull request #1503: PHOENIX-6773 PhoenixDatabaseMetadata.getColumns() always returns null COLUMN_DEF

Aarchy commented on code in PR #1503:
URL: https://github.com/apache/phoenix/pull/1503#discussion_r977371170


##########
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java:
##########
@@ -852,7 +852,7 @@ public ResultSet getColumns(String catalog, String schemaPattern, String tableNa
                 cells.add(
                     PhoenixKeyValueUtil.newKeyValue(rowKey, TABLE_FAMILY_BYTES,
                         Bytes.toBytes(COLUMN_DEF),
-                        MetaDataProtocol.MIN_TABLE_TIMESTAMP, ByteUtil.EMPTY_BYTE_ARRAY));
+                        MetaDataProtocol.MIN_TABLE_TIMESTAMP, PVarchar.INSTANCE.toBytes(column.getExpressionStr())));

Review Comment:
   Thanks, fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org