You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Brian Bockelman (JIRA)" <ji...@apache.org> on 2009/03/26 17:10:10 UTC
[jira] Created: (HADOOP-5581) libhdfs does not get
FileNotFoundException
libhdfs does not get FileNotFoundException
------------------------------------------
Key: HADOOP-5581
URL: https://issues.apache.org/jira/browse/HADOOP-5581
Project: Hadoop Core
Issue Type: Bug
Components: dfs, libhdfs
Affects Versions: 0.19.1
Reporter: Brian Bockelman
When trying to open a file that does not exist for read, libhdfs prints an error out along the line of "Cannot open file <filename>".
I believe it should be throwing the FileNotFoundException instead. This would allow us to correctly set the errno and more naturally give the errors to the C-based clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5581) libhdfs does not get
FileNotFoundException
Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Bockelman updated HADOOP-5581:
------------------------------------
Fix Version/s: 0.20.0
0.19.2
Status: Patch Available (was: Open)
> libhdfs does not get FileNotFoundException
> ------------------------------------------
>
> Key: HADOOP-5581
> URL: https://issues.apache.org/jira/browse/HADOOP-5581
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Fix For: 0.19.2, 0.20.0
>
> Attachments: HADOOP-5581.patch
>
>
> When trying to open a file that does not exist for read, libhdfs prints an error out along the line of "Cannot open file <filename>".
> I believe it should be throwing the FileNotFoundException instead. This would allow us to correctly set the errno and more naturally give the errors to the C-based clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5581) libhdfs does not get
FileNotFoundException
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12697793#action_12697793 ]
Hadoop QA commented on HADOOP-5581:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12404491/HADOOP-5581-v2.patch
against trunk revision 763728.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/179/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/179/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/179/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/179/console
This message is automatically generated.
> libhdfs does not get FileNotFoundException
> ------------------------------------------
>
> Key: HADOOP-5581
> URL: https://issues.apache.org/jira/browse/HADOOP-5581
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Assignee: Brian Bockelman
> Fix For: 0.19.2, 0.20.0
>
> Attachments: HADOOP-5581-v2.patch, HADOOP-5581.patch
>
>
> When trying to open a file that does not exist for read, libhdfs prints an error out along the line of "Cannot open file <filename>".
> I believe it should be throwing the FileNotFoundException instead. This would allow us to correctly set the errno and more naturally give the errors to the C-based clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5581) libhdfs does not get
FileNotFoundException
Posted by "Craig Macdonald (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689853#action_12689853 ]
Craig Macdonald commented on HADOOP-5581:
-----------------------------------------
Hi Brian, Two small questions:
(a) Can you comment on how this relates to HADOOP-5579?
(b) I can't see "Cannot open file" in the current trunk of hdfs.c - do you know where this is coming from?
> libhdfs does not get FileNotFoundException
> ------------------------------------------
>
> Key: HADOOP-5581
> URL: https://issues.apache.org/jira/browse/HADOOP-5581
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
>
> When trying to open a file that does not exist for read, libhdfs prints an error out along the line of "Cannot open file <filename>".
> I believe it should be throwing the FileNotFoundException instead. This would allow us to correctly set the errno and more naturally give the errors to the C-based clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5581) libhdfs does not get
FileNotFoundException
Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Bockelman updated HADOOP-5581:
------------------------------------
Attachment: HADOOP-5581.patch
This patch causes HDFS to throw a FileNotFoundException in FSNamesystem instead of a generic IOException.
HADOOP-5579 fixes the parsing of the FileNotFoundException; with this patch, it should propagate the errno correctly.
> libhdfs does not get FileNotFoundException
> ------------------------------------------
>
> Key: HADOOP-5581
> URL: https://issues.apache.org/jira/browse/HADOOP-5581
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Attachments: HADOOP-5581.patch
>
>
> When trying to open a file that does not exist for read, libhdfs prints an error out along the line of "Cannot open file <filename>".
> I believe it should be throwing the FileNotFoundException instead. This would allow us to correctly set the errno and more naturally give the errors to the C-based clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5581) libhdfs does not get
FileNotFoundException
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-5581:
---------------------------------
Status: Patch Available (was: Open)
> libhdfs does not get FileNotFoundException
> ------------------------------------------
>
> Key: HADOOP-5581
> URL: https://issues.apache.org/jira/browse/HADOOP-5581
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Assignee: Brian Bockelman
> Fix For: 0.19.2, 0.20.0
>
> Attachments: HADOOP-5581-v2.patch, HADOOP-5581.patch
>
>
> When trying to open a file that does not exist for read, libhdfs prints an error out along the line of "Cannot open file <filename>".
> I believe it should be throwing the FileNotFoundException instead. This would allow us to correctly set the errno and more naturally give the errors to the C-based clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5581) libhdfs does not get
FileNotFoundException
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-5581:
---------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.19.2)
(was: 0.20.0)
0.21.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this to trunk. Thanks Brian.
This is not marked a blocker for 0.19 and 0.20.
> libhdfs does not get FileNotFoundException
> ------------------------------------------
>
> Key: HADOOP-5581
> URL: https://issues.apache.org/jira/browse/HADOOP-5581
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Assignee: Brian Bockelman
> Fix For: 0.21.0
>
> Attachments: HADOOP-5581-v2.patch, HADOOP-5581.patch
>
>
> When trying to open a file that does not exist for read, libhdfs prints an error out along the line of "Cannot open file <filename>".
> I believe it should be throwing the FileNotFoundException instead. This would allow us to correctly set the errno and more naturally give the errors to the C-based clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5581) libhdfs does not get
FileNotFoundException
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693598#action_12693598 ]
Raghu Angadi commented on HADOOP-5581:
--------------------------------------
Patch looks fine. A few improvements :
JavaDoc for getBlockLocations could be modifed to make this a part of the contract.
Do we need any text for FNF excepton?
Instead of adding a new test, a test simple test case could be added to another test (e.g. TestDistributedFIleSystem.java). That way it comes almost for free (see test added in HADOOP-5191). Each new test adds on the order of 7-10 seconds, however simple it is.
> libhdfs does not get FileNotFoundException
> ------------------------------------------
>
> Key: HADOOP-5581
> URL: https://issues.apache.org/jira/browse/HADOOP-5581
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Fix For: 0.19.2, 0.20.0
>
> Attachments: HADOOP-5581.patch
>
>
> When trying to open a file that does not exist for read, libhdfs prints an error out along the line of "Cannot open file <filename>".
> I believe it should be throwing the FileNotFoundException instead. This would allow us to correctly set the errno and more naturally give the errors to the C-based clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5581) libhdfs does not get
FileNotFoundException
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695208#action_12695208 ]
Raghu Angadi commented on HADOOP-5581:
--------------------------------------
+1.
Regd the contract, it needs to be added to ClientProtocol.getBlockLocations() and FNF is not the only exception. It is ok for now.
> libhdfs does not get FileNotFoundException
> ------------------------------------------
>
> Key: HADOOP-5581
> URL: https://issues.apache.org/jira/browse/HADOOP-5581
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Fix For: 0.19.2, 0.20.0
>
> Attachments: HADOOP-5581-v2.patch, HADOOP-5581.patch
>
>
> When trying to open a file that does not exist for read, libhdfs prints an error out along the line of "Cannot open file <filename>".
> I believe it should be throwing the FileNotFoundException instead. This would allow us to correctly set the errno and more naturally give the errors to the C-based clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5581) libhdfs does not get
FileNotFoundException
Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Bockelman updated HADOOP-5581:
------------------------------------
Attachment: HADOOP-5581-v2.patch
Patch updated - made a note in the javadoc that getBlockLocation throws FNF. Used TestDistributedFileSystem class instead of a new test class.
> libhdfs does not get FileNotFoundException
> ------------------------------------------
>
> Key: HADOOP-5581
> URL: https://issues.apache.org/jira/browse/HADOOP-5581
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Fix For: 0.19.2, 0.20.0
>
> Attachments: HADOOP-5581-v2.patch, HADOOP-5581.patch
>
>
> When trying to open a file that does not exist for read, libhdfs prints an error out along the line of "Cannot open file <filename>".
> I believe it should be throwing the FileNotFoundException instead. This would allow us to correctly set the errno and more naturally give the errors to the C-based clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5581) libhdfs does not get
FileNotFoundException
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700727#action_12700727 ]
Hudson commented on HADOOP-5581:
--------------------------------
Integrated in Hadoop-trunk #811 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/811/])
> libhdfs does not get FileNotFoundException
> ------------------------------------------
>
> Key: HADOOP-5581
> URL: https://issues.apache.org/jira/browse/HADOOP-5581
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Assignee: Brian Bockelman
> Fix For: 0.21.0
>
> Attachments: HADOOP-5581-v2.patch, HADOOP-5581.patch
>
>
> When trying to open a file that does not exist for read, libhdfs prints an error out along the line of "Cannot open file <filename>".
> I believe it should be throwing the FileNotFoundException instead. This would allow us to correctly set the errno and more naturally give the errors to the C-based clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5581) libhdfs does not get
FileNotFoundException
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693527#action_12693527 ]
Hadoop QA commented on HADOOP-5581:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12404071/HADOOP-5581.patch
against trunk revision 759398.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/77/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/77/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/77/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/77/console
This message is automatically generated.
> libhdfs does not get FileNotFoundException
> ------------------------------------------
>
> Key: HADOOP-5581
> URL: https://issues.apache.org/jira/browse/HADOOP-5581
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Fix For: 0.19.2, 0.20.0
>
> Attachments: HADOOP-5581.patch
>
>
> When trying to open a file that does not exist for read, libhdfs prints an error out along the line of "Cannot open file <filename>".
> I believe it should be throwing the FileNotFoundException instead. This would allow us to correctly set the errno and more naturally give the errors to the C-based clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5581) libhdfs does not get
FileNotFoundException
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-5581:
---------------------------------
Status: Open (was: Patch Available)
> libhdfs does not get FileNotFoundException
> ------------------------------------------
>
> Key: HADOOP-5581
> URL: https://issues.apache.org/jira/browse/HADOOP-5581
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Assignee: Brian Bockelman
> Fix For: 0.19.2, 0.20.0
>
> Attachments: HADOOP-5581-v2.patch, HADOOP-5581.patch
>
>
> When trying to open a file that does not exist for read, libhdfs prints an error out along the line of "Cannot open file <filename>".
> I believe it should be throwing the FileNotFoundException instead. This would allow us to correctly set the errno and more naturally give the errors to the C-based clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-5581) libhdfs does not get
FileNotFoundException
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur reassigned HADOOP-5581:
----------------------------------------
Assignee: Brian Bockelman
> libhdfs does not get FileNotFoundException
> ------------------------------------------
>
> Key: HADOOP-5581
> URL: https://issues.apache.org/jira/browse/HADOOP-5581
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, libhdfs
> Affects Versions: 0.19.1
> Reporter: Brian Bockelman
> Assignee: Brian Bockelman
> Fix For: 0.19.2, 0.20.0
>
> Attachments: HADOOP-5581-v2.patch, HADOOP-5581.patch
>
>
> When trying to open a file that does not exist for read, libhdfs prints an error out along the line of "Cannot open file <filename>".
> I believe it should be throwing the FileNotFoundException instead. This would allow us to correctly set the errno and more naturally give the errors to the C-based clients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.