You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/02/15 02:47:00 UTC

[jira] [Commented] (GEODE-6322) CreateRegionCommand generates unexpected region attributes

    [ https://issues.apache.org/jira/browse/GEODE-6322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768893#comment-16768893 ] 

ASF subversion and git services commented on GEODE-6322:
--------------------------------------------------------

Commit 189d6fb94f3a7e0a0eb8f5c3bca52d613b6e5760 in geode's branch refs/heads/develop from jinmeiliao
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=189d6fb ]

GEODE-6322: refactor createRegionCommand to use RegionConfig only (#3156)

* get rid of usages of xxxArgs and RegionConfigFactory
* the resulting cluster configuration xml for region does not have excessive default values


> CreateRegionCommand generates unexpected region attributes
> ----------------------------------------------------------
>
>                 Key: GEODE-6322
>                 URL: https://issues.apache.org/jira/browse/GEODE-6322
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>            Reporter: Jinmei Liao
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> For example, when creating PARTITION or REPLICATE regions, the following xml is persisted:
> {code:xml}
> <?xml version="1.0" encoding="UTF-8" standalone="no"?>
> <cache xmlns="http://geode.apache.org/schema/cache" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.0" xsi:schemaLocation="http://geode.apache.org/schema/cache http://geode.apache.org/schema/cache/cache-1.0.xsd">
>     <region name="PARTITION">
>         <region-attributes cloning-enabled="false" concurrency-checks-enabled="true" concurrency-level="16" data-policy="partition" disk-synchronous="true" enable-async-conflation="false" enable-subscription-conflation="false" multicast-enabled="false" off-heap="false" statistics-enabled="false">
>             <partition-attributes local-max-memory="441" recovery-delay="-1" redundant-copies="0" startup-recovery-delay="0" total-max-memory="2147483647" total-num-buckets="113"/>
>         </region-attributes>
>     </region>
>     <region name="REPLICATE">
>         <region-attributes cloning-enabled="false" concurrency-checks-enabled="true" concurrency-level="16" data-policy="replicate" disk-synchronous="true" enable-async-conflation="false" enable-subscription-conflation="false" multicast-enabled="false" off-heap="false" scope="distributed-ack" statistics-enabled="false"/>
>     </region>
> </cache>
> {code}
> Instead, it should be:
> {code:xml}
> <?xml version="1.0" encoding="UTF-8" standalone="no"?>
> <cache xsi:schemaLocation="http://geode.apache.org/schema/cache http://geode.apache.org/schema/cache/cache-1.0.xsd" xmlns="http://geode.apache.org/schema/cache" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
> <region name="PARTITION">
>     <region-attributes data-policy="partition"/>
>   </region>
>   <region name="REPLICATE">
>       <region-attributes data-policy="replicate" scope="distributed-ack"/>
>     </region>
> </cache>
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)