You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "stevomitric (via GitHub)" <gi...@apache.org> on 2026/09/05 21:04:02 UTC

[PR] [MINOR][SQL] Remove stale "Hash is not implemented" comment for nanosecond timestamp physical types [spark]

stevomitric opened a new pull request, #58546:
URL: https://github.com/apache/spark/pull/58546

   
   ### What changes were proposed in this pull request?
   Delete the obsolete scaladoc line from PhysicalTimestampNTZNanosType and PhysicalTimestampLTZNanosType. Hashing for the nanosecond carrier (TimestampNanosVal.hashCode) was implemented in SPARK-57103 and is used by hash aggregate/join, DISTINCT, and set membership, so the "Hash is not implemented yet" note is false and misleading.
   
   ### Why are the changes needed?
   Update the scaladocs.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Linter.
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [MINOR][SQL] Remove stale "Hash is not implemented" comment for nanosecond timestamp physical types [spark]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #58546:
URL: https://github.com/apache/spark/pull/58546#issuecomment-5560218390

   LGTM, thank you @stevomitric!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [MINOR][SQL] Remove stale "Hash is not implemented" comment for nanosecond timestamp physical types [spark]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #58546:
URL: https://github.com/apache/spark/pull/58546#issuecomment-5560234785

   **Merge Summary:**
   - merged into master https://github.com/apache/spark/commit/ea926c075cefc6239734ccacdb52c076b9180654
   - merged into branch-4.x https://github.com/apache/spark/commit/66bec0c55b218848070d6775abed047546dce45f
   
   *Posted by `merge_spark_pr.py`*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [MINOR][SQL] Remove stale "Hash is not implemented" comment for nanosecond timestamp physical types [spark]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b closed pull request #58546: [MINOR][SQL] Remove stale "Hash is not implemented" comment for nanosecond timestamp physical types
URL: https://github.com/apache/spark/pull/58546


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [MINOR][SQL] Remove stale "Hash is not implemented" comment for nanosecond timestamp physical types [spark]

Posted by "stevomitric (via GitHub)" <gi...@apache.org>.
stevomitric commented on PR #58546:
URL: https://github.com/apache/spark/pull/58546#issuecomment-5555512033

   cc @uros-b PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org