You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by "Zhe (Joe) Wang" <jw...@hortonworks.com> on 2016/02/20 00:39:09 UTC

Review Request 43791: AMBARI-15120 Alerts UI Usability Changes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43791/
-----------------------------------------------------------

Review request for Ambari, Richard Zang, Srimanth Gunturi, and Yusaku Sako.


Bugs: AMBARI-15120
    https://issues.apache.org/jira/browse/AMBARI-15120


Repository: ambari


Description
-------

1) Remove host badge from Hosts tab
2) On summary page, next to component "Started" text, need to show if a component has alerts


Diffs
-----

  ambari-web/app/controllers/main/host.js d3574b2 
  ambari-web/app/controllers/main/service/info/summary.js 0e6cc88 
  ambari-web/app/data/host/categories.js 7e010d5 
  ambari-web/app/mappers/alert_definition_summary_mapper.js 69f1b16 
  ambari-web/app/models/host_component.js 61a51cd 
  ambari-web/app/styles/alerts.less 1b8d5f4 
  ambari-web/app/templates/main/menu_item.hbs bd471b4 
  ambari-web/app/templates/main/service/info/summary/master_components.hbs b4ef0af 
  ambari-web/app/views/main/menu.js 697c85d 

Diff: https://reviews.apache.org/r/43791/diff/


Testing
-------

Local ambari-web test passed.
24306 tests complete (22 seconds)
146 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 43791: AMBARI-15120 Alerts UI Usability Changes

Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43791/#review120248
-----------------------------------------------------------


Ship it!




Ship It!

- Richard Zang


On Feb. 23, 2016, 2:28 a.m., Zhe (Joe) Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43791/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 2:28 a.m.)
> 
> 
> Review request for Ambari, Richard Zang, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15120
>     https://issues.apache.org/jira/browse/AMBARI-15120
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1) Remove host badge from Hosts tab
> 2) On summary page, next to component "Started" text, need to show if a component has alerts
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/host.js d3574b2 
>   ambari-web/app/controllers/main/service/info/summary.js 0e6cc88 
>   ambari-web/app/data/host/categories.js 7e010d5 
>   ambari-web/app/mappers/alert_definition_summary_mapper.js 69f1b16 
>   ambari-web/app/models/host_component.js 61a51cd 
>   ambari-web/app/styles/alerts.less d4e5d27 
>   ambari-web/app/templates/main/menu_item.hbs bd471b4 
>   ambari-web/app/templates/main/service/info/summary/master_components.hbs b4ef0af 
>   ambari-web/app/views/main/menu.js 697c85d 
> 
> Diff: https://reviews.apache.org/r/43791/diff/
> 
> 
> Testing
> -------
> 
> Local ambari-web test passed.
> 24306 tests complete (22 seconds)
> 146 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 43791: AMBARI-15120 Alerts UI Usability Changes

Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43791/
-----------------------------------------------------------

(Updated Feb. 23, 2016, 2:28 a.m.)


Review request for Ambari, Richard Zang, Srimanth Gunturi, and Yusaku Sako.


Bugs: AMBARI-15120
    https://issues.apache.org/jira/browse/AMBARI-15120


Repository: ambari


Description
-------

1) Remove host badge from Hosts tab
2) On summary page, next to component "Started" text, need to show if a component has alerts


Diffs (updated)
-----

  ambari-web/app/controllers/main/host.js d3574b2 
  ambari-web/app/controllers/main/service/info/summary.js 0e6cc88 
  ambari-web/app/data/host/categories.js 7e010d5 
  ambari-web/app/mappers/alert_definition_summary_mapper.js 69f1b16 
  ambari-web/app/models/host_component.js 61a51cd 
  ambari-web/app/styles/alerts.less d4e5d27 
  ambari-web/app/templates/main/menu_item.hbs bd471b4 
  ambari-web/app/templates/main/service/info/summary/master_components.hbs b4ef0af 
  ambari-web/app/views/main/menu.js 697c85d 

Diff: https://reviews.apache.org/r/43791/diff/


Testing
-------

Local ambari-web test passed.
24306 tests complete (22 seconds)
146 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang