[GitHub] [lucene-solr] uschindler edited a comment on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

[GitBox <gi...@apache.org>]

uschindler edited a comment on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-728774023


   Hi,
   We can also remove WindowsDirectory. This one was not done for direct IO, but in my opinion, it's obsolete, too: https://issues.apache.org/jira/browse/LUCENE-2791
   
   It was made for the case where SimpleFSDirectory was slow in earlier days, because java's default RandomAccessFile was not able to do positional IO from multiple threads. We may review this again, but as most people use MMAPDirectory this is really obsolete.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org