You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/03/04 08:35:33 UTC

[GitHub] [rocketmq] cserwen commented on a change in pull request #3928: fix the issue.

cserwen commented on a change in pull request #3928:
URL: https://github.com/apache/rocketmq/pull/3928#discussion_r819364947



##########
File path: tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtImpl.java
##########
@@ -913,7 +913,7 @@ public boolean consumed(final MessageExt msg,
         final String group) throws RemotingException, MQClientException, InterruptedException,
         MQBrokerException {
 
-        ConsumeStats cstats = this.examineConsumeStats(group);
+        ConsumeStats cstats = this.examineConsumeStats(group,msg.getTopic());
 
         ClusterInfo ci = this.examineBrokerClusterInfo();
 

Review comment:
       The following codes are used to check topic . Maybe you can simplify it.
   
   https://github.com/apache/rocketmq/blob/e7ee1186b5f1b9a46da67e3d71cc7e01c27600bd/tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtImpl.java#L921
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org