You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2019/03/09 23:22:28 UTC

[GitHub] [drill] vvysotskyi opened a new pull request #1686: DRILL-6524: Prevent incorrect scalar replacement for the case of assigning references inside if block

vvysotskyi opened a new pull request #1686: DRILL-6524: Prevent incorrect scalar replacement for the case of assigning references inside if block
URL: https://github.com/apache/drill/pull/1686
 
 
   This pull request contains two commits:
   - The first one contains changes to prevent incorrect scalar replacement for the case of assigning references inside if block to avoid wrong results for some cases
   - The second commit contains changes to assign holder fields inside of assigning just object reference for the case when the source object is not used anymore (a common example is the result of UDF execution), so it will allow using scalar replacement more frequently.
   
   Therefore with these two commits, a scalar replacement will be produced correctly and more frequently despite preventing it in the first commit.
   
   For detailed problem description please see comment in [DRILL-6524](https://issues.apache.org/jira/browse/DRILL-6524)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services