You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/23 02:32:15 UTC
[GitHub] [incubator-apisix] gxthrj opened a new pull request #1891: style:modify kubernetes doc,make config.yaml from the latest version …
gxthrj opened a new pull request #1891:
URL: https://github.com/apache/incubator-apisix/pull/1891
### What this PR does / why we need it:
1.make config.yaml from the latest version
2.remove some config not necessary
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [x] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #1891: doc(k8s): removed unnecessary configurations.
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1891:
URL: https://github.com/apache/incubator-apisix/pull/1891#discussion_r459378802
##########
File path: kubernetes/README.md
##########
@@ -21,7 +21,17 @@
There are some yaml files for deploying apisix in Kubernetes.
### Prerequisites
-- Install etcd
+- Install etcd , and set env `etcd_url` in config.sh
+
+- Run `config.sh` to generate apisix-gw-config-cm.yaml from the latest `config.yaml`
Review comment:
to generate the `apisix-gw-config-cm.yaml`
##########
File path: kubernetes/config.sh
##########
@@ -0,0 +1,12 @@
+#!/bin/sh
+
+export etcd_url='http://here_is_you_etcd_IP:2379'
Review comment:
`http://$ETCD_IP_ADDRESS:2379`
##########
File path: kubernetes/README.md
##########
@@ -21,7 +21,17 @@
There are some yaml files for deploying apisix in Kubernetes.
### Prerequisites
-- Install etcd
+- Install etcd , and set env `etcd_url` in config.sh
Review comment:
We could use ``` to include keywords, e.g `etcd`
##########
File path: kubernetes/README.md
##########
@@ -56,7 +66,7 @@ or
$ kubectl create configmap apisix-gw-config.yaml --from-file=../conf/config.yaml
```
-##### Note: you should modify etcd addr in config file `apisix-gw-config-cm.yaml` or `../conf/config.yaml` first
+##### Note: you should check etcd addr in config file `apisix-gw-config-cm.yaml` or `../conf/config.yaml` first, make sure the etcd addresses are right.
Review comment:
`are correct`.
##########
File path: kubernetes/README.md
##########
@@ -21,7 +21,17 @@
There are some yaml files for deploying apisix in Kubernetes.
### Prerequisites
-- Install etcd
+- Install etcd , and set env `etcd_url` in config.sh
+
+- Run `config.sh` to generate apisix-gw-config-cm.yaml from the latest `config.yaml`
+
+```
Review comment:
```sh
# if config.sh have no permission to execute, then execute `chmod +x config.sh` to generate apisix-gw-config-cm.yaml
$ sh config.sh
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] gxthrj commented on pull request #1891: doc(k8s): removed unnecessary configurations.
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #1891:
URL: https://github.com/apache/incubator-apisix/pull/1891#issuecomment-665438941
> @gxthrj please take a look at the output of Github Action:
>
> https://github.com/apache/incubator-apisix/pull/1891/checks?check_run_id=913422137#step:6:61
>
> ```
> Scan detected 2 error(s) in 2 file(s):
> Reading configuration file [.travis/ASF-Release.cfg]...
> Scanning files starting at [./]...
> Scan detected 2 error(s) in 2 file(s):
> [./kubernetes/config.sh]:
> 1: file does not include required license header.
> [./kubernetes/deployment.yaml]:
> 113: file does not end with EOL.
> ```
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on pull request #1891: doc(k8s): removed unnecessary configurations.
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1891:
URL: https://github.com/apache/incubator-apisix/pull/1891#issuecomment-665071773
@gxthrj please take a look at the output of Github Action:
https://github.com/apache/incubator-apisix/pull/1891/checks?check_run_id=913422137#step:6:61
```
Scan detected 2 error(s) in 2 file(s):
Reading configuration file [.travis/ASF-Release.cfg]...
Scanning files starting at [./]...
Scan detected 2 error(s) in 2 file(s):
[./kubernetes/config.sh]:
1: file does not include required license header.
[./kubernetes/deployment.yaml]:
113: file does not end with EOL.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] moonming merged pull request #1891: doc(k8s): removed unnecessary configurations.
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #1891:
URL: https://github.com/apache/incubator-apisix/pull/1891
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] juzhiyuan commented on a change in pull request #1891: doc(k8s): removed unnecessary configurations.
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1891:
URL: https://github.com/apache/incubator-apisix/pull/1891#discussion_r459378636
##########
File path: kubernetes/README.md
##########
@@ -21,7 +21,17 @@
There are some yaml files for deploying apisix in Kubernetes.
### Prerequisites
-- Install etcd
+- Install etcd , and set env `etcd_url` in config.sh
Review comment:
use `etcd` would be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org