You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/06/12 10:45:36 UTC
[GitHub] [incubator-apisix-dashboard] gxthrj opened a new pull request #257: add grafana & fix some bug
gxthrj opened a new pull request #257:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/257
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] gxthrj commented on pull request #257: add grafana & fix some bug
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #257:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/257#issuecomment-643885560
> How about rename to `apisix_http_prometheus.json'?
>
> `compose/grafana_conf/dashboards/apisix.json`
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on pull request #257: add grafana & fix some bug
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #257:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/257#issuecomment-643881154
Any updates?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #257: add grafana & fix some bug
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #257:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/257#discussion_r439912809
##########
File path: api/build.sh
##########
@@ -1,20 +1,3 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one or more
Review comment:
Please add the ASF header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] moonming commented on pull request #257: add grafana & fix some bug
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #257:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/257#issuecomment-643269935
yes, we need the asf header
琚致远 <no...@github.com> 于 2020年6月12日周五 下午9:16写道：
> *@juzhiyuan* requested changes on this pull request.
> ------------------------------
>
> In compose/grafana_conf/provisioning/dashboards/all.yaml
> <https://github.com/apache/incubator-apisix-dashboard/pull/257#discussion_r439411241>
> :
>
> > @@ -0,0 +1,11 @@
> +apiVersion: 1
> +
> +providers:
> +- name: 'default'
> + orgId: 1
> + folder: ''
> + type: file
> + disableDeletion: false
> + editable: false
> + options:
> + path: /var/lib/grafana/dashboards
>
> It should be dashboard
> ------------------------------
>
> In api/build.sh
> <https://github.com/apache/incubator-apisix-dashboard/pull/257#discussion_r439411495>
> :
>
> > @@ -1,20 +1,3 @@
> -#
> -# Licensed to the Apache Software Foundation (ASF) under one or more
>
> @moonming <https://github.com/moonming> We may still need this header,
> right?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-apisix-dashboard/pull/257#pullrequestreview-429730171>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGJZBK2GNTQ2JBVCA7BYYRTRWITCLANCNFSM4N4G4IRQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] gxthrj commented on a change in pull request #257: add grafana & fix some bug
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #257:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/257#discussion_r439914838
##########
File path: api/build.sh
##########
@@ -1,20 +1,3 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one or more
Review comment:
this is a mistake, should start with `#!/bin/sh` in this file, and the headers are following.
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #257: add grafana & fix some bug
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #257:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/257#discussion_r439912735
##########
File path: compose/grafana_conf/provisioning/dashboards/all.yaml
##########
@@ -0,0 +1,11 @@
+apiVersion: 1
+
+providers:
+- name: 'default'
+ orgId: 1
+ folder: ''
+ type: file
+ disableDeletion: false
+ editable: false
+ options:
+ path: /var/lib/grafana/dashboards
Review comment:
We use `dashboards` here because of the grafana may include multiple Dashboard, not because the word works here 😑
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] gxthrj commented on a change in pull request #257: add grafana & fix some bug
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #257:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/257#discussion_r439896095
##########
File path: compose/grafana_conf/provisioning/dashboards/all.yaml
##########
@@ -0,0 +1,11 @@
+apiVersion: 1
+
+providers:
+- name: 'default'
+ orgId: 1
+ folder: ''
+ type: file
+ disableDeletion: false
+ editable: false
+ options:
+ path: /var/lib/grafana/dashboards
Review comment:
Using `dashboards` can also work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #257: add grafana & fix some bug
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #257:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/257
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] membphis commented on pull request #257: add grafana & fix some bug
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #257:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/257#issuecomment-643208421
How about rename to `apisix_http_prometheus.json'?
`compose/grafana_conf/dashboards/apisix.json`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #257: add grafana & fix some bug
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #257:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/257#discussion_r439411241
##########
File path: compose/grafana_conf/provisioning/dashboards/all.yaml
##########
@@ -0,0 +1,11 @@
+apiVersion: 1
+
+providers:
+- name: 'default'
+ orgId: 1
+ folder: ''
+ type: file
+ disableDeletion: false
+ editable: false
+ options:
+ path: /var/lib/grafana/dashboards
Review comment:
It should be `dashboard`
##########
File path: api/build.sh
##########
@@ -1,20 +1,3 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one or more
Review comment:
@moonming We may still need this header, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] gxthrj commented on pull request #257: add grafana & fix some bug
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #257:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/257#issuecomment-643885455
> apisix_http_prometheus
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org