[GitHub] [incubator-pekko-persistence-dynamodb] mdedetrich commented on a diff in pull request #13: Protect against doing requests for snapshots that are over 400KB.

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #13:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/13#discussion_r1117455690


##########
src/main/scala/akka/persistence/dynamodb/snapshot/DynamoDBSnapshotStore.scala:
##########
@@ -12,6 +12,8 @@ import com.typesafe.config.Config
 import akka.persistence.dynamodb._
 import scala.concurrent.Future
 
+class DynamoDBSnapshotRejection(message: String, cause: Throwable = null) extends RuntimeException(message, cause)

Review Comment:
   Can we add a `Key` field as a `val` to this exception so we know which key caused the exception incase people want to catch it.
   
   Also mention the key in the exception message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org