[Axis2]SOAP header blocks hash table- why?

[Samisa Abeysinghe <sa...@gmail.com>]

Why are we keeping the header blocks in a hash table in SOAP header struct?

We are using the key to be a number:
sprintf(key,"%d", header_impl->hbnumber++);
    if(header_impl->header_blocks)
    {
        axis2_hash_set(header_impl->header_blocks,
             key , AXIS2_HASH_KEY_STRING, header_block);
    }

I see no use case to use this number to access the header blocks. IMHO, 
we can keep the stuff in an array list.

Samisa...

[Axis2]OM node struct add child bug?

[Samisa Abeysinghe <sa...@gmail.com>]

Nandika,

In include/axis2_om_node.h, we have the macro:
#define AXIS2_OM_NODE_ADD_CHILD(om_node,env,parent) \
        ((parent)->ops->add_child(om_node,env,parent))

Should tis not be:
#define AXIS2_OM_NODE_ADD_CHILD(om_node, env, child) \
        ((om_node)->ops->add_child(om_node, env, child))

PS: the macro code also violates coding convention; should have a space 
after a comma.

Samisa...