You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/16 08:36:26 UTC

[GitHub] [airflow] ashb commented on a change in pull request #17630: Do not delete running DAG from the UI

ashb commented on a change in pull request #17630:
URL: https://github.com/apache/airflow/pull/17630#discussion_r689341994



##########
File path: airflow/api/common/experimental/delete_dag.py
##########
@@ -40,6 +41,11 @@ def delete_dag(dag_id: str, keep_records_in_log: bool = True, session=None) -> i
     :return count of deleted dags
     """
     log.info("Deleting DAG: %s", dag_id)
+    running_tis = (
+        session.query(models.TaskInstance.state).filter(models.TaskInstance.state.in_(State.unfinished)).all()

Review comment:
       Doesn't this catch _any_ running TIs, not just TIs for _this DAG_?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org