You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/04/21 10:52:47 UTC
[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #5688: [Bug-fix] lock db when get table from catalog
EmmyMiao87 opened a new pull request #5688:
URL: https://github.com/apache/incubator-doris/pull/5688
Although the table lock can control the simultaneous modification of the table by different threads.
But it cannot control the drop operation of the table by other threads.
For example, when drop table and table update occur at the same time.
1. get table object by thread 1
2. drop table by thread 2 with table lock
3. update table object by thread 1
The above process is possible.
At this time, step 3 actually operates a table that no longer exists, which will eventually cause the wrong metadata to be recorded.
Fixed #5687
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on (Fix #5687) and described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on pull request #5688: [Bug-fix] lock db when get table from catalog
Posted by GitBox <gi...@apache.org>.
caiconghui commented on pull request #5688:
URL: https://github.com/apache/incubator-doris/pull/5688#issuecomment-823982423
can we just simply skip replayUpdateReplica if table has been dropped. because someone may drop db, so we still need to lock catalog?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #5688: [Bug-fix] lock db when get table from catalog
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #5688:
URL: https://github.com/apache/incubator-doris/pull/5688#issuecomment-824153454
If this problem occurs, there is something wrong with the metadata access mechanism itself.
And this error may happen again.
I think a simpler way is to judge if table is null in the `unprotectUpdateReplica()` method of `Catalog`, return directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #5688: [Bug-fix] Ignore modified table log when table has been dropped
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #5688:
URL: https://github.com/apache/incubator-doris/pull/5688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #5688: [Bug-fix] lock db when get table from catalog
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on pull request #5688:
URL: https://github.com/apache/incubator-doris/pull/5688#issuecomment-824491431
> can we just simply skip replayUpdateReplica if table has been dropped. because someone may drop db, so we still need to lock catalog?
Indeed, if we have to add db locks for this situation, basically table locks are of little significance.
I will consider skipping the replay log if the table does not exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org