You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by Byung-Gon Chun <bg...@gmail.com> on 2018/06/11 22:52:33 UTC
Committer guide updated
Hi,
Wonook updated the committer guide to accept PRs. Thanks, Wonook!
https://cwiki.apache.org/confluence/display/REEF/Accepting+Pull+Requests
As you can see, it's much simpler than the old guide. :)
Take a look. If you'd like to update it, please feel free to do.
Cheers,
Gon
--
Byung-Gon Chun
Re: Committer guide updated
Posted by Byung-Gon Chun <bg...@gmail.com>.
Good catch, Sergiy. :-)
Thanks.
-Gon
On Sat, Jun 16, 2018 at 6:57 AM, Sergiy Matusevych <
sergiy.matusevych@gmail.com> wrote:
> Also, on the git setup page, at
> https://cwiki.apache.org/confluence/display/REEF/GIT+Setup+for+Committers
>
> do we have the right URL? Shouldn't the git remote line be
>
> git remote add apache https://gitbox.apache.org/repos/asf/reef.git
>
> Just asking :)
>
> Thanks,
> Sergiy.
>
--
Byung-Gon Chun
Re: Committer guide updated
Posted by Sergiy Matusevych <se...@gmail.com>.
Also, on the git setup page, at
https://cwiki.apache.org/confluence/display/REEF/GIT+Setup+for+Committers
do we have the right URL? Shouldn't the git remote line be
git remote add apache https://gitbox.apache.org/repos/asf/reef.git
Just asking :)
Thanks,
Sergiy.
Re: Committer guide updated
Posted by Byung-Gon Chun <bg...@gmail.com>.
Thanks, Wonook.
We no longer have a proper commit message to use in the guide. But we still
need a proper commit message format.
The commit message after merging the latest PR is as follows.
The first line comes from the PR title. Note that it includes PR number
(#1476).
The rest of the message is what I entered in the PR description.
Do we still need "Pull Request:\n This closes #XXXX"?
Thanks.
-Gon
[REEF-2016] Fix CreateUriForPath methods of different IFileSystems to
not append prefix if given path already contains it (#1476)
* Fix CreateUriForPath methods of different Ifilesystems not to
append prefix if given path already
contains it
* Update tests related to file systems
JIRA: [REEF-2016](httaps://issues.apache.org/jira/browse/REEF-2016)
Pull Request:
This closes #1476
On Wed, Jun 13, 2018 at 3:07 AM, 송원욱 <wo...@apache.org> wrote:
> Sure, I've added the part that you're concerned with by adding appropriate
> screenshots on the 'Merge changes' subsection on the site
> <https://cwiki.apache.org/confluence/display/REEF/Accepting+Pull+Requests>
> Wonook
>
>
> 2018년 6월 12일 (화) 오후 7:31, Byung-Gon Chun <bg...@gmail.com>님이 작성:
>
> > Wonook, if we just merge a PR, the commit message in the gitbox repo
> > history is not what we want.
> > https://gitbox.apache.org/repos/asf?p=reef.git
> > Note that the last commit message is "Merge pull request #1475 from
> > DifferentSC/REEF-2019".
> >
> > Did you discuss this issue in the guide?
> >
> > Thanks.
> > -Gon
> >
> >
> > On Tue, Jun 12, 2018 at 7:52 AM, Byung-Gon Chun <bg...@gmail.com>
> wrote:
> >
> > > Hi,
> > >
> > > Wonook updated the committer guide to accept PRs. Thanks, Wonook!
> > > https://cwiki.apache.org/confluence/display/REEF/
> Accepting+Pull+Requests
> > >
> > > As you can see, it's much simpler than the old guide. :)
> > > Take a look. If you'd like to update it, please feel free to do.
> > >
> > > Cheers,
> > > Gon
> > >
> > > --
> > > Byung-Gon Chun
> > >
> >
> >
> >
> > --
> > Byung-Gon Chun
> >
>
--
Byung-Gon Chun
Re: Committer guide updated
Posted by 송원욱 <wo...@apache.org>.
Sure, I've added the part that you're concerned with by adding appropriate
screenshots on the 'Merge changes' subsection on the site
<https://cwiki.apache.org/confluence/display/REEF/Accepting+Pull+Requests>
Wonook
2018년 6월 12일 (화) 오후 7:31, Byung-Gon Chun <bg...@gmail.com>님이 작성:
> Wonook, if we just merge a PR, the commit message in the gitbox repo
> history is not what we want.
> https://gitbox.apache.org/repos/asf?p=reef.git
> Note that the last commit message is "Merge pull request #1475 from
> DifferentSC/REEF-2019".
>
> Did you discuss this issue in the guide?
>
> Thanks.
> -Gon
>
>
> On Tue, Jun 12, 2018 at 7:52 AM, Byung-Gon Chun <bg...@gmail.com> wrote:
>
> > Hi,
> >
> > Wonook updated the committer guide to accept PRs. Thanks, Wonook!
> > https://cwiki.apache.org/confluence/display/REEF/Accepting+Pull+Requests
> >
> > As you can see, it's much simpler than the old guide. :)
> > Take a look. If you'd like to update it, please feel free to do.
> >
> > Cheers,
> > Gon
> >
> > --
> > Byung-Gon Chun
> >
>
>
>
> --
> Byung-Gon Chun
>
Re: Committer guide updated
Posted by Byung-Gon Chun <bg...@gmail.com>.
Wonook, if we just merge a PR, the commit message in the gitbox repo
history is not what we want. https://gitbox.apache.org/repos/asf?p=reef.git
Note that the last commit message is "Merge pull request #1475 from
DifferentSC/REEF-2019".
Did you discuss this issue in the guide?
Thanks.
-Gon
On Tue, Jun 12, 2018 at 7:52 AM, Byung-Gon Chun <bg...@gmail.com> wrote:
> Hi,
>
> Wonook updated the committer guide to accept PRs. Thanks, Wonook!
> https://cwiki.apache.org/confluence/display/REEF/Accepting+Pull+Requests
>
> As you can see, it's much simpler than the old guide. :)
> Take a look. If you'd like to update it, please feel free to do.
>
> Cheers,
> Gon
>
> --
> Byung-Gon Chun
>
--
Byung-Gon Chun