Re: [PR] [feat][broker] add consumer first consume/flow timestamp [pulsar]

["lhotari (via GitHub)" <gi...@apache.org>]

lhotari commented on code in PR #24247:
URL: https://github.com/apache/pulsar/pull/24247#discussion_r2074158432


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java:
##########
@@ -435,6 +437,9 @@ public Future<Void> sendMessages(final List<? extends Entry> entries,
         writeAndFlushPromise.addListener(status -> {
             // only increment counters after the messages have been successfully written to the TCP/IP connection
             if (status.isSuccess()) {
+                if (firstConsumedTimestamp == 0) {
+                    firstConsumedTimestamp =  System.currentTimeMillis();
+                }

Review Comment:
   just wondering if this makes sense since `flowPermits` method would get called before messages get sent to a consumer?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org