You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/05/17 15:12:51 UTC
Re: Review Request 58048: Added id to Resource.DiskInfo.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review175252
-----------------------------------------------------------
src/tests/resources_tests.cpp
Lines 2190 (patched)
<https://reviews.apache.org/r/58048/#comment248705>
Unused variable?
- Qian Zhang
On April 5, 2017, 9:56 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated April 5, 2017, 9:56 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac
> include/mesos/v1/mesos.proto 228623155c7f68c0f24d173aacbc6eb734f1382f
> src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a
> src/tests/mesos.hpp fe897c184829910addec95ace174546092a9e2b2
> src/tests/resources_tests.cpp 343cab2af225a05e32c5a8bd4a5d9ddfbf76536d
> src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11
>
>
> Diff: https://reviews.apache.org/r/58048/diff/3/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 58048: Added id to Resource.DiskInfo.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On May 17, 2017, 5:12 p.m., Qian Zhang wrote:
> > src/tests/resources_tests.cpp
> > Lines 2190 (patched)
> > <https://reviews.apache.org/r/58048/diff/3/?file=1685272#file1685272line2190>
> >
> > Unused variable?
Thanks, also fixed the other sites.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review175252
-----------------------------------------------------------
On May 19, 2017, 11:16 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 11:16 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto e138e2aedb1369acdde82facf9dfea9780411154
> include/mesos/v1/mesos.proto ab617bfd2bc46e44f7d71cefecf5eac3630d22b3
> src/common/resources.cpp 1d07f1a049ba3bb3f5d78f05031f33ba97e07e8c
> src/tests/mesos.hpp 3c57f25ff0bec55582b8a7decef53be61a9ec6f4
> src/tests/resources_tests.cpp 5dcbce2dd4944194b59790551929d6d75b805ba3
> src/v1/resources.cpp 1bb5d0741c9f9ea59f34e92159a335661019444d
>
>
> Diff: https://reviews.apache.org/r/58048/diff/4/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>