[GitHub] [rocketmq] ni-ze commented on a change in pull request #3365: [ISSUE #3366] Allocate MessageQueue to client first by same Machine IP.

[GitBox <gi...@apache.org>]

ni-ze commented on a change in pull request #3365:
URL: https://github.com/apache/rocketmq/pull/3365#discussion_r713653321



##########
File path: broker/src/main/java/org/apache/rocketmq/broker/processor/QueryAssignmentProcessor.java
##########
@@ -220,13 +220,13 @@ private RemotingCommand queryAssignment(ChannelHandlerContext ctx, RemotingComma
                         } else {
                             if (cidAll.size() <= mqAll.size()) {
                                 //consumer working in pop mode could share the MessageQueues assigned to the N (N = popWorkGroupSize) consumer following it in the cid list
-                                allocateResult = allocateMessageQueueStrategy.allocate(consumerGroup, clientId, mqAll, cidAll);
+                                allocateResult = allocateMessageQueueStrategy.allocate(null, consumerGroup, clientId, mqAll, cidAll);

Review comment:
       QueryAssignmentProcessor and AllocateMessageQueueStrategy always  has same version, new version of QueryAssignmentProcessor will not depend on old AllocateMessageQueueStrategy interface.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org