[GitHub] [iceberg] hililiwei commented on a diff in pull request #7362: Flink 1.17: Supports batch queries using time ranges

["hililiwei (via GitHub)" <gi...@apache.org>]

hililiwei commented on code in PR #7362:
URL: https://github.com/apache/iceberg/pull/7362#discussion_r1168546532


##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/FlinkSplitPlanner.java:
##########
@@ -97,11 +98,15 @@ static CloseableIterable<CombinedScanTask> planTasks(
       }
 
       if (context.startSnapshotId() != null) {
-        Preconditions.checkArgument(
-            context.startTag() == null, "START_SNAPSHOT_ID and START_TAG cannot both be set");

Review Comment:
   Verify in ScanContext.java. It's not necessary here.
   
   



##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/FlinkSplitPlanner.java:
##########
@@ -111,11 +116,14 @@ static CloseableIterable<CombinedScanTask> planTasks(
       }
 
       if (context.endSnapshotId() != null) {
-        Preconditions.checkArgument(
-            context.endTag() == null, "END_SNAPSHOT_ID and END_TAG cannot both be set");

Review Comment:
   Verify in ScanContext.java. It's not necessary here.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org