You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by caofangkun <gi...@git.apache.org> on 2016/01/08 09:59:25 UTC

[GitHub] storm pull request: [STORM-1453] nimbus.clj/wait-for-desired-code-...

GitHub user caofangkun opened a pull request:

    https://github.com/apache/storm/pull/996

    [STORM-1453] nimbus.clj/wait-for-desired-code-replication print wrong log message

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/caofangkun/apache-storm storm-1453

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/996.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #996
    
----
commit ed25dfda1f47a6fffcaea681f0a395f274ff1bf6
Author: ablecao <ab...@tencent.com>
Date:   2016-01-08T08:56:58Z

    [STORM-1453] nimbus.clj/wait-for-desired-code-replication print wrong log message

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1453] nimbus.clj/wait-for-desired-code-...

Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/996#issuecomment-170584316
  
    +1, but this needs to be upmerged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1453] nimbus.clj/wait-for-desired-code-...

Posted by caofangkun <gi...@git.apache.org>.
Github user caofangkun closed the pull request at:

    https://github.com/apache/storm/pull/996


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1453] nimbus.clj/wait-for-desired-code-...

Posted by caofangkun <gi...@git.apache.org>.
Github user caofangkun commented on the pull request:

    https://github.com/apache/storm/pull/996#issuecomment-170755067
  
    Updated as PR #1003 
    
    Close this PR .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1453] nimbus.clj/wait-for-desired-code-...

Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:

    https://github.com/apache/storm/pull/996#issuecomment-170039698
  
    Test failures are the same, and they look unrelated.  We may want a new Jira created under [STORM-915](https://issues.apache.org/jira/browse/STORM-915).
    
    ```
    Running storm.kafka.bolt.KafkaBoltTest
    Tests run: 8, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 14.346 sec <<< FAILURE! - in storm.kafka.bolt.KafkaBoltTest
    executeWithByteArrayKeyAndMessageFire(storm.kafka.bolt.KafkaBoltTest)  Time elapsed: 1.71 sec  <<< ERROR!
    storm.kafka.TopicOffsetOutOfRangeException: Partition{host=localhost:59874, topic=test-topic, partition=0} Got fetch request with offset out of range: [-1]
    	at storm.kafka.KafkaUtils.fetchMessages(KafkaUtils.java:203)
    	at storm.kafka.bolt.KafkaBoltTest.verifyMessage(KafkaBoltTest.java:275)
    	at storm.kafka.bolt.KafkaBoltTest.executeWithByteArrayKeyAndMessageFire(KafkaBoltTest.java:188)
    ```
    
    +1



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---