You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2014/09/22 16:32:09 UTC
Review Request 25894: Issues on upgrade ambari
1.6.0->1.7.0(ambari+mysql)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25894/
-----------------------------------------------------------
Review request for Ambari and Myroslav Papirkovskyy.
Bugs: AMBARI-7433
https://issues.apache.org/jira/browse/AMBARI-7433
Repository: ambari
Description
-------
1) "UPDATE viewinstance SET config_id = (SELECT @a := @a + 1 FROM (SELECT @a := 1) s)" is not correct. We should update clusterconfig, not viewinstance.
2) "dbAccessor.setNullable("clusterconfig", "version", false); " doesn't work for mysql(syntax error). Change it to execute quesrry: dbAccessor.executeQuery("ALTER TABLE clusterconfig MODIFY version BIGINT NOT NULL");
3) dbAccessor.executeQuery("ALTER TABLE ambari_sequences RENAME COLUMN value to sequence_value DECIMAL(38) NOT NULL"); is not correct for mysql. Should be changed to dbAccessor.executeQuery("ALTER TABLE ambari_sequences CHANGE value sequence_value DECIMAL(38) NOT NULL")
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 1313a3f
Diff: https://reviews.apache.org/r/25894/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 25894: Issues on upgrade ambari
1.6.0->1.7.0(ambari+mysql)
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25894/#review54129
-----------------------------------------------------------
Ship it!
Please, create additional JIRA, regarding not working setNullable for MySQL. (We cannot make it work as is as MySQL requires data type also to modify column, not just column name)
- Myroslav Papirkovskyy
On Вер. 22, 2014, 5:32 після полудня, Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25894/
> -----------------------------------------------------------
>
> (Updated Вер. 22, 2014, 5:32 після полудня)
>
>
> Review request for Ambari and Myroslav Papirkovskyy.
>
>
> Bugs: AMBARI-7433
> https://issues.apache.org/jira/browse/AMBARI-7433
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1) "UPDATE viewinstance SET config_id = (SELECT @a := @a + 1 FROM (SELECT @a := 1) s)" is not correct. We should update clusterconfig, not viewinstance.
>
> 2) "dbAccessor.setNullable("clusterconfig", "version", false); " doesn't work for mysql(syntax error). Change it to execute quesrry: dbAccessor.executeQuery("ALTER TABLE clusterconfig MODIFY version BIGINT NOT NULL");
>
> 3) dbAccessor.executeQuery("ALTER TABLE ambari_sequences RENAME COLUMN value to sequence_value DECIMAL(38) NOT NULL"); is not correct for mysql. Should be changed to dbAccessor.executeQuery("ALTER TABLE ambari_sequences CHANGE value sequence_value DECIMAL(38) NOT NULL")
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 1313a3f
>
> Diff: https://reviews.apache.org/r/25894/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>