[GitHub] [iceberg] rdblue commented on a change in pull request #1094: Add ignoreResiduals to TableScan

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1094:
URL: https://github.com/apache/iceberg/pull/1094#discussion_r435574455



##########
File path: core/src/main/java/org/apache/iceberg/AllDataFilesTable.java
##########
@@ -85,19 +86,23 @@ public Schema schema() {
 
     private AllDataFilesTableScan(
         TableOperations ops, Table table, Long snapshotId, Schema schema, Expression rowFilter,
-        boolean caseSensitive, boolean colStats, Collection<String> selectedColumns, Schema fileSchema,
+        boolean ignoreResiduals, boolean caseSensitive, boolean colStats,
+        Collection<String> selectedColumns, Schema fileSchema,
         ImmutableMap<String, String> options) {
-      super(ops, table, snapshotId, schema, rowFilter, caseSensitive, colStats, selectedColumns, options);
+      super(
+          ops, table, snapshotId, schema, rowFilter, ignoreResiduals,
+          caseSensitive, colStats, selectedColumns, options);

Review comment:
       What about not supporting this option for metadata tables? It doesn't seem necessary and if we can simplify this PR, that would be helpful.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org