You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2015/01/13 12:18:41 UTC
Review Request 29846: Upgrade UI: Use item text and context for
display
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29846/
-----------------------------------------------------------
Review request for Ambari, Andrii Tkach and Nate Cole.
Bugs: AMBARI-9103
https://issues.apache.org/jira/browse/AMBARI-9103
Repository: ambari
Description
-------
The UpgradeItem/context field is used to show detail of items on the upgrade UI. Instead, the UpgradeItem/context field should be used with the item display (sub-accordian of the group) and the UpgradeItem/text field should be used to show the actual instructions. For example, manual step instructions should be from UpgradeItem/text, not UpgradeItem/context.
Diffs
-----
ambari-web/app/assets/data/stack_versions/upgrade.json a8cecc3ee0bce3946ee67210ef3bcb6acaa7432a
ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs b4a153216b25b347f60fedb9af58ab6dcb1c0a41
Diff: https://reviews.apache.org/r/29846/diff/
Testing
-------
5218 tests complete (7 seconds)
60 tests pending
Thanks,
Andriy Babiichuk
Re: Review Request 29846: Upgrade UI: Use item text and context for
display
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29846/#review67848
-----------------------------------------------------------
Ship it!
Ship It!
- Andrii Tkach
On Янв. 13, 2015, 11:18 д.п., Andriy Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29846/
> -----------------------------------------------------------
>
> (Updated Янв. 13, 2015, 11:18 д.п.)
>
>
> Review request for Ambari, Andrii Tkach and Nate Cole.
>
>
> Bugs: AMBARI-9103
> https://issues.apache.org/jira/browse/AMBARI-9103
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The UpgradeItem/context field is used to show detail of items on the upgrade UI. Instead, the UpgradeItem/context field should be used with the item display (sub-accordian of the group) and the UpgradeItem/text field should be used to show the actual instructions. For example, manual step instructions should be from UpgradeItem/text, not UpgradeItem/context.
>
>
> Diffs
> -----
>
> ambari-web/app/assets/data/stack_versions/upgrade.json a8cecc3ee0bce3946ee67210ef3bcb6acaa7432a
> ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs b4a153216b25b347f60fedb9af58ab6dcb1c0a41
>
> Diff: https://reviews.apache.org/r/29846/diff/
>
>
> Testing
> -------
>
> 5218 tests complete (7 seconds)
> 60 tests pending
>
>
> Thanks,
>
> Andriy Babiichuk
>
>