You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/12/09 22:04:23 UTC

[GitHub] [drill] pjfanning edited a comment on pull request #2400: DRILL-8071: use excel cell.getLocalDateTimeCellValue

pjfanning edited a comment on pull request #2400:
URL: https://github.com/apache/drill/pull/2400#issuecomment-990324203


   @cgivre I removed the new logging
   
   I agree that it would be nice to have some configuration to decide what to with errors. I think this PR is probably better to stick to just the date time conversion issue.
   
   If Drill does not currently have support for supporting conversion errors - could I suggest that one possible approach is to have excel-like cell comments? - so that Drill could put a default value in the Drill cell equivalent but attach a comment with the error. It would still be useful to support fail fast as an option too (ie fail the upload if any cells can't be loaded as the type the schema says they are).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org