You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by Patrick Kling <pk...@cs.uwaterloo.ca> on 2010/11/02 04:31:23 UTC
Review Request: Allow configuration changes without restarting configured
nodes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21/
-----------------------------------------------------------
Review request for hadoop-common.
Summary
-------
Allow configuration changes without restarting configured nodes
This addresses bug HADOOP-7001.
https://issues.apache.org/jira/browse/HADOOP-7001
Diffs
-----
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/Configuration.java 1026174
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/Reconfigurable.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurableBase.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationException.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationServlet.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationUtil.java PRE-CREATION
Diff: https://reviews.apache.org/r/21/diff
Testing
-------
Manual testing with Reconfigurable NameNode from https://issues.apache.org/jira/browse/HDFS-1477
Thanks,
Patrick
Re: Review Request: Allow configuration changes without restarting
configured nodes
Posted by Todd Lipcon <to...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21/#review22
-----------------------------------------------------------
I'm not so sure about making all of the Configuration methods synchronized. For one in terms of deadlock possibility, for two in terms of performance. Is this really necessary?
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/Reconfigurable.java
<https://reviews.apache.org/r/21/#comment11>
typo: a the
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/Reconfigurable.java
<https://reviews.apache.org/r/21/#comment12>
Collection<String> seems more general
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationServlet.java
<https://reviews.apache.org/r/21/#comment13>
why commented out?
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationServlet.java
<https://reviews.apache.org/r/21/#comment14>
need escaping on all interpolated values throughout
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationUtil.java
<https://reviews.apache.org/r/21/#comment15>
this could be unit tested
- Todd
On 2010-11-01 20:31:22, Patrick Kling wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21/
> -----------------------------------------------------------
>
> (Updated 2010-11-01 20:31:22)
>
>
> Review request for hadoop-common.
>
>
> Summary
> -------
>
> Allow configuration changes without restarting configured nodes
>
>
> This addresses bug HADOOP-7001.
> https://issues.apache.org/jira/browse/HADOOP-7001
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/Configuration.java 1026174
> http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/Reconfigurable.java PRE-CREATION
> http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurableBase.java PRE-CREATION
> http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationException.java PRE-CREATION
> http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationServlet.java PRE-CREATION
> http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationUtil.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21/diff
>
>
> Testing
> -------
>
> Manual testing with Reconfigurable NameNode from https://issues.apache.org/jira/browse/HDFS-1477
>
>
> Thanks,
>
> Patrick
>
>
Re: Review Request: Allow configuration changes without restarting
configured nodes
Posted by Patrick Kling <pk...@cs.uwaterloo.ca>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21/
-----------------------------------------------------------
(Updated 2010-11-18 23:25:47.603882)
Review request for hadoop-common.
Changes
-------
Fixed warnings.
Summary
-------
Allow configuration changes without restarting configured nodes
This addresses bug HADOOP-7001.
https://issues.apache.org/jira/browse/HADOOP-7001
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/Configuration.java 1026174
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/Reconfigurable.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurableBase.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationException.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationServlet.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationUtil.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/test/core/org/apache/hadoop/conf/TestReconfiguration.java PRE-CREATION
Diff: https://reviews.apache.org/r/21/diff
Testing
-------
Manual testing with Reconfigurable NameNode from https://issues.apache.org/jira/browse/HDFS-1477
TestReconfiguration unit tests
Thanks,
Patrick
Re: Review Request: Allow configuration changes without restarting
configured nodes
Posted by Patrick Kling <pk...@cs.uwaterloo.ca>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21/
-----------------------------------------------------------
(Updated 2010-11-02 13:35:03.413064)
Review request for hadoop-common.
Summary
-------
Allow configuration changes without restarting configured nodes
This addresses bug HADOOP-7001.
https://issues.apache.org/jira/browse/HADOOP-7001
Diffs
-----
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/Configuration.java 1026174
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/Reconfigurable.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurableBase.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationException.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationServlet.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationUtil.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/test/core/org/apache/hadoop/conf/TestReconfiguration.java PRE-CREATION
Diff: https://reviews.apache.org/r/21/diff
Testing (updated)
-------
Manual testing with Reconfigurable NameNode from https://issues.apache.org/jira/browse/HDFS-1477
TestReconfiguration unit tests
Thanks,
Patrick
Re: Review Request: Allow configuration changes without restarting
configured nodes
Posted by Patrick Kling <pk...@cs.uwaterloo.ca>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21/
-----------------------------------------------------------
(Updated 2010-11-02 13:32:50.159119)
Review request for hadoop-common.
Changes
-------
Incorporated Todd's comments. Thank you!
- Added unit tests for ReconfigurationUtil.getChangedProperties, Reconfigurable interface methods and cross-thread visibility of configuration changes.
- Added proper escaping to servlet.
- Removed synchronization from Configuration methods that were already protected by synchronization of getProps(). In this revision, I have only added synchronization to the setter methods.
- Changed getReconfigurableProperties to return Collection rather than List.
- Fixed typo.
- Removed commented-out code.
- Removed unnecessary imports.
Summary
-------
Allow configuration changes without restarting configured nodes
This addresses bug HADOOP-7001.
https://issues.apache.org/jira/browse/HADOOP-7001
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/Configuration.java 1026174
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/Reconfigurable.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurableBase.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationException.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationServlet.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/java/org/apache/hadoop/conf/ReconfigurationUtil.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/common/trunk/src/test/core/org/apache/hadoop/conf/TestReconfiguration.java PRE-CREATION
Diff: https://reviews.apache.org/r/21/diff
Testing
-------
Manual testing with Reconfigurable NameNode from https://issues.apache.org/jira/browse/HDFS-1477
Thanks,
Patrick