[GitHub] ashb commented on a change in pull request #2135: [AIRFLOW-843] Store exceptions on task_instance

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #2135: [AIRFLOW-843] Store exceptions on task_instance
URL: https://github.com/apache/incubator-airflow/pull/2135#discussion_r212655832
 
 

 ##########
 File path: airflow/models.py
 ##########
 @@ -1574,6 +1574,8 @@ def dry_run(self):
     def handle_failure(self, error, test_mode=False, context=None, session=None):
         self.log.exception(error)
         task = self.task
+        session = settings.Session()
+        self.exception = error
 
 Review comment:
   Adding a property to the TaskInstance object feels the wrong place for this - the context object feels like a more appropriate place.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services