[GitHub] [helix] kaisun2000 commented on pull request #1620: Skeleton per-replica stage with one simple test (1st)

[GitBox <gi...@apache.org>]

kaisun2000 commented on pull request #1620:
URL: https://github.com/apache/helix/pull/1620#issuecomment-768708525


   > I see the new classes are not licensed. Please do so.
   > 
   > Moreover, I guess you didn't get my point of adding the test. Sorry that I should have made it clearer.
   > Overall, we want the PR to be small for reviewing. And it against our original goal that you add more logic back just to make the test complete. The test should cover whatever the code logic has, but the reverse way. For example, as I mentioned that the original logic only generates the empty result. This is hard to test. But you can just copy-paste whatever in the MessageOutput into the new throttling stage's result. In this case, I don't think you will need to add all the logic in [4d452e7](https://github.com/apache/helix/commit/4d452e76497d713e86acccc1d05e99d48c6ddac0).
   > And the test will verify 2 things only: 1. the stage can run without exception. 2. the output contains all the messages.
   
   Changed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org